Skip to content

Run OTel integration tests when span-emitting task runner code changes #69250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jason810496 merged 1 commit into from
Jul 3, 2026
+7 −0
Merged

Run OTel integration tests when span-emitting task runner code changes #69250

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions dev/breeze/doc/ci/04_selective_checks.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,7 @@ representative examples (file → effect):
| `scripts/ci/prek/check_*.py` (static-check hook) | CI image + static checks, **no full matrix** | prek hooks are static checks → `Prek files` carve-out |
| the generated OpenAPI spec | **full matrix** | the API *contract* ripples to UI codegen + every client |
| `chart/templates/...yaml` (on `main`) | `run_helm_tests` (+ PROD image) | matches `HELM_FILES`; Helm tests only on `main` |
| `task-sdk/.../task_runner.py` or `airflow-core/tests/integration/otel/...` | the `otel` core integration | matches `OTEL_FILES`; the otel integration tests assert the span hierarchy task_runner emits |
| `airflow-core/src/airflow/ui/...tsx` only | `run_ui_tests`, **no** unit tests | "only new-UI files" short-circuit skips Python unit tests |

The "complexity" you feel reading the code is just *many* such rules stacked up — each one on its own
Expand Down
4 changes: 4 additions & 0 deletions dev/breeze/src/airflow_breeze/utils/selective_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,6 +464,10 @@ def __hash__(self):
r"^airflow-core/src/airflow/observability/.*",
r"^shared/observability/src/airflow_shared/observability/.*",
r"^airflow-core/src/airflow/utils/span_status\.py$",
# The otel integration tests assert the exact span hierarchy that
# task_runner emits, so changes to either must exercise the integration.
r"^airflow-core/tests/integration/otel/.*",
r"^task-sdk/src/airflow/sdk/execution_time/task_runner\.py$",
],
FileGroupForCi.CELERY_FILES: [
# Core executor sources - redis is celery's broker/result backend, so the
Expand Down
2 changes: 2 additions & 0 deletions dev/breeze/tests/test_selective_checks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3419,6 +3419,8 @@ def test_testable_providers_integrations_excludes_arm_disabled_on_arm():
[
pytest.param("airflow-core/src/airflow/security/kerberos.py", "kerberos", id="kerberos-source"),
pytest.param("airflow-core/src/airflow/observability/stats.py", "otel", id="otel-source"),
pytest.param("airflow-core/tests/integration/otel/test_otel.py", "otel", id="otel-integration-tests"),
pytest.param("task-sdk/src/airflow/sdk/execution_time/task_runner.py", "otel", id="otel-task-runner"),
pytest.param("airflow-core/src/airflow/executors/executor_loader.py", "redis", id="celery-source"),
],
)
Expand Down