Run OTel integration tests when span-emitting task runner code changes#69250
Merged
jason810496 merged 1 commit intoJul 3, 2026
Merged
Conversation
The otel core integration was only triggered by observability sources, so PRs changing the spans the task runner emits (like apache#67877) or the otel integration tests themselves passed CI without running the tests that assert the span hierarchy, and breakage surfaced only in canary builds.
jason810496
requested review from
amoghrajesh,
ashb,
bugraoz93,
choo121600,
ephraimbuddy,
gopidesupavan,
jedcunningham,
jscheffl,
potiuk and
vatsrahul1001
as code owners
boring-cyborg
Bot
added
area:dev-tools
backport-to-v3-3-test
Member
|
I think it was a temp issue with back-compat - re-running to double check |
Member
Author
Yes, the CI all pass now, thanks. |
bugraoz93
approved these changes
Jul 2, 2026
Contributor
Backport successfully created: v3-3-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
vatsrahul1001
pushed a commit
that referenced
this pull request
Jul 3, 2026
… code changes (#69250) The otel core integration was only triggered by observability sources, so PRs changing the spans the task runner emits (like #67877) or the otel integration tests themselves passed CI without running the tests that assert the span hierarchy, and breakage surfaced only in canary builds. (cherry picked from commit 5298431) Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
potiuk
added a commit
that referenced
this pull request
Jul 3, 2026
… code changes (#69250) (#69285) The otel core integration was only triggered by observability sources, so PRs changing the spans the task runner emits (like #67877) or the otel integration tests themselves passed CI without running the tests that assert the span hierarchy, and breakage surfaced only in canary builds. (cherry picked from commit 5298431) Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com> Co-authored-by: Jarek Potiuk <jarek@potiuk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#67877 changed the spans emitted by the task runner and broke the OTel integration test, but its CI never ran that test: neither
task_runner.pynor the otel integration tests themselves are in theOTEL_FILESselective-checks group, sotestable-core-integrationsstayed empty and the failure only surfaced in the canary build (fixed in #69236).What
airflow-core/tests/integration/otel/andtask-sdk/.../task_runner.pytoOTEL_FILESso touching either triggers theotelcore integration.dev/breeze/doc/ci/04_selective_checks.mdandtest_selective_checks.pyaccordingly.Was generative AI tooling used to co-author this PR?