Support require_approval in LLMBranchOperator - #70651
Merged
Merged
Conversation
kaxil
reviewed
Jul 30, 2026
Member
|
Screenshot/video of how it works e2e would be ideal |
Reviewers previously had to recall downstream task IDs from memory when modifying a choice, and an empty reviewed list silently skipped every downstream task. The review form now lists valid branches and renders a dropdown for single-branch mode, empty selections are rejected, and the duplicated require_approval prompt check lives on the approval mixin.
guan404ming
force-pushed
the
llm-branch-require-approval
branch
from
August 3, 2026 02:08
c70e92b to
533dda9
Compare
Member
Author
|
Attached an e2e demo: trigger, review with branch dropdown, approve modified choice, downstream branches run/skip. llm_branch_approval_demo.webm |
kaxil
reviewed
Aug 3, 2026
kaxil
reviewed
Aug 3, 2026
kaxil
approved these changes
Aug 3, 2026
1 task
Member
Author
|
Thanks for the review, I'll merge this first and will follow up to refine this. |
1 task
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
require_approval=Truewas rejected onLLMBranchOperator; this implements it.How
do_branchonly after approval.require_approvalbefore agent runs.E2E verified in breeze: pause, modified approval, correct skip.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Fable 5) following the guidelines