Skip downstream tasks on LLMBranchOperator reject - #71073
Open
guan404ming wants to merge 1 commit into
Open
Conversation
guan404ming
marked this pull request as ready for review
August 4, 2026 15:09
guan404ming
requested review from
Lee-W,
gopidesupavan and
kaxil
as code owners
August 4, 2026 15:09
guan404ming
force-pushed
the
llm-branch-reject-skip
branch
from
August 4, 2026 17:40
3f6f5f9 to
5e7f377
Compare
guan404ming
force-pushed
the
llm-branch-reject-skip
branch
from
August 5, 2026 12:36
5e7f377 to
a8db156
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
LLMBranchOperatorreview failed the task, leaving downstream tasksupstream_failed.ApprovalOperatortreats reject as a human decision and skips downstream instead; failing on reject is documented as generally discouraged.How
do_branch(context, None), skipping every downstream task.fail_on_rejectflag (defaultFalse) restores the old fail behavior, mirroringApprovalOperator.approval_timeoutexpiry still fails the task.E2E
Verified in breeze: trigger, review pauses the task, hit Reject,
route_ticketendssuccessand all downstream branches endskipped(previouslyupstream_failed).llm_branch_reject_skip_demo.webm
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Fable 5) following the guidelines