GH-36618: [C++] Add a test for evaluation of ARROW_CHECK payload

[pitrou]

We want to make sure that the error description payload for ARROW_CHECK is only evaluated if the check fails.

• Closes: [C++] Add a test for evaluation of ARROW_CHECK payload #36618

[github-actions]

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

In the case of PARQUET issues on JIRA the title also supports:

PARQUET-${JIRA_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

See also:

• Other pull requests
• Contribution Guidelines - How to contribute patches

[pitrou]

@felipecrv

[github-actions]

⚠️ GitHub issue #36618 has been automatically assigned in GitHub to PR creator.

[pitrou]

Thanks for the review @felipecrv . CI failures are unrelated, will merge.

[conbench-apache-arrow]

After merging your PR, Conbench analyzed the 6 benchmarking runs that have been run so far on merge-commit 0e0df29.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details. It also includes information about possible false positives for unstable benchmarks that are known to sometimes produce them.