Skip to content

GH-36618: [C++] Add a test for evaluation of ARROW_CHECK payload #36617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitrou merged 1 commit into from
Jul 11, 2023
Merged

GH-36618: [C++] Add a test for evaluation of ARROW_CHECK payload #36617

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions cpp/src/arrow/util/logging_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,33 @@ TEST(PrintLogTest, LogTestWithInit) {
ArrowLog::ShutDownArrowLog();
}

struct LoggingTracer {
mutable bool was_printed = false;

friend std::ostream& operator<<(std::ostream& os, const LoggingTracer& x) {
x.was_printed = true;
return os;
}
};

TEST(ArrowCheck, PayloadNotEvaluatedOnSuccess) {
volatile bool cond = true;
LoggingTracer tracer;

ARROW_CHECK_OR_LOG(cond, WARNING) << "Some message" << tracer;
ASSERT_FALSE(tracer.was_printed);
}

TEST(ArrowCheck, PayloadEvaluatedOnFailure) {
volatile bool cond = false;
LoggingTracer tracer;

// Have to use a log level that actually gets printed, otherwise `operator<<`
// isn't called (which is good except for this test).
ARROW_CHECK_OR_LOG(cond, WARNING) << "Some message" << tracer;
ASSERT_TRUE(tracer.was_printed);
}

} // namespace util

TEST(DcheckMacros, DoNotEvaluateReleaseMode) {
Expand Down