Skip to content

GH-46488 [C#] Switch to license expression#46624

Closed
thompson-tomo wants to merge 1 commit into
apache:mainfrom
thompson-tomo:patch-1
Closed

GH-46488 [C#] Switch to license expression#46624
thompson-tomo wants to merge 1 commit into
apache:mainfrom
thompson-tomo:patch-1

Conversation

@thompson-tomo
Copy link
Copy Markdown

@thompson-tomo thompson-tomo commented May 28, 2025

What changes are included in this PR?

Update to csproj property

Are these changes tested?

Yes

Are there any user-facing changes?

No

Closes #46488

@github-actions
Copy link
Copy Markdown

Thanks for opening a pull request!

If this is not a minor PR. Could you open an issue for this pull request on GitHub? https://github.com/apache/arrow/issues/new/choose

Opening GitHub issues ahead of time contributes to the Openness of the Apache Arrow project.

Then could you also rename the pull request title in the following format?

GH-${GITHUB_ISSUE_ID}: [${COMPONENT}] ${SUMMARY}

or

MINOR: [${COMPONENT}] ${SUMMARY}

See also:

@thompson-tomo thompson-tomo changed the title #46488 switch to license expression GH-46488 switch to license expression May 28, 2025
@github-actions
Copy link
Copy Markdown

⚠️ GitHub issue #46488 has been automatically assigned in GitHub to PR creator.

@thompson-tomo thompson-tomo changed the title GH-46488 switch to license expression GH-46488 [C-sharp] switch to license expression May 28, 2025
@kou kou changed the title GH-46488 [C-sharp] switch to license expression GH-46488 [C#] Switch to license expression May 28, 2025
@@ -45,7 +45,7 @@
<Authors>The Apache Software Foundation</Authors>
<PackageIcon>feather.png</PackageIcon>
<!-- We can't use PackageLicenseExpression; the license file also contains 3rd-party notices. -->
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you read this comment?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but when you review the third party notices, they are referring to the other languages ie cpp. At the same time on reviewing the source code, I couldn't find a source file which didn't have the Apache licence header or wasn't auto generated. Based on that it should be possible to move most if not all packages from the deprecated property to the replacement.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At the same time on reviewing the source code, I couldn't find a source file which didn't have the Apache licence header or wasn't auto generated.

How did you do it? Could you clarify it to clear our license?

BTW, we'll move csharp/ in apache/arrow to apache/arrow-dotnet: apache/arrow-dotnet#1

Can we work on this after it?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you do it? Could you clarify it to clear our license?

I manually went through checking files in each of the projects including the sub folders.

BTW, we'll move csharp/ in apache/arrow to apache/arrow-dotnet: apache/arrow-dotnet#1

Can we work on this after it?

sure that is fine

@CurtHagenlocher
Copy link
Copy Markdown
Contributor

Thanks for the suggestion, @thompson-tomo! I've implemented the change at apache/arrow-dotnet#185.

@thompson-tomo thompson-tomo deleted the patch-1 branch November 18, 2025 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[C#] Switch to license expression

3 participants