Remove previous workarounds for when super() could not be pickled on Py3#39187
Remove previous workarounds for when super() could not be pickled on Py3#39187ByteFlowing1337 wants to merge 2 commits into
super() could not be pickled on Py3#39187Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request cleans up technical debt by removing outdated workarounds previously required for pickling Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request cleans up workaround code related to BEAM-6158 across several Python examples. It replaces explicit base class initialization calls (such as beam.PTransform.init(self) and beam.DoFn.init(self)) with standard super().init() calls, and removes the obsolete TODO comments. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #39187 +/- ##
============================================
+ Coverage 55.33% 55.39% +0.06%
Complexity 2198 2198
============================================
Files 1107 1107
Lines 172166 172335 +169
Branches 1417 1417
============================================
+ Hits 95267 95465 +198
+ Misses 74462 74433 -29
Partials 2437 2437
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Assigning reviewers: R: @shunping for label python. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
|
@shunping Do you mind reviewing this PR? |
Related to #7710 and BEAM-6158.
Since uqfoundation/dill#300 was resolved a long time ago, we should revert these workarounds now.