Skip to content

Remove previous workarounds for when super() could not be pickled on Py3#39187

Open
ByteFlowing1337 wants to merge 2 commits into
apache:masterfrom
ByteFlowing1337:fix-6158
Open

Remove previous workarounds for when super() could not be pickled on Py3#39187
ByteFlowing1337 wants to merge 2 commits into
apache:masterfrom
ByteFlowing1337:fix-6158

Conversation

@ByteFlowing1337

Copy link
Copy Markdown

Related to #7710 and BEAM-6158.

Since uqfoundation/dill#300 was resolved a long time ago, we should revert these workarounds now.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request cleans up technical debt by removing outdated workarounds previously required for pickling super() calls in Python 3. By reverting to standard super().__init__() calls, the codebase is now more idiomatic and aligned with modern Python practices, following the resolution of the underlying issue in the dill library.

Highlights

  • Code Cleanup: Removed legacy workarounds that manually called base class constructors in __init__ methods across multiple Apache Beam examples.
  • Modernization: Updated class initializers to use the standard super().__init__() pattern, now that dill supports pickling super() objects in Python 3.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request cleans up workaround code related to BEAM-6158 across several Python examples. It replaces explicit base class initialization calls (such as beam.PTransform.init(self) and beam.DoFn.init(self)) with standard super().init() calls, and removes the obsolete TODO comments. There are no review comments, and I have no additional feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 55.39%. Comparing base (30a5a00) to head (bb84e40).
⚠️ Report is 12 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #39187      +/-   ##
============================================
+ Coverage     55.33%   55.39%   +0.06%     
  Complexity     2198     2198              
============================================
  Files          1107     1107              
  Lines        172166   172335     +169     
  Branches       1417     1417              
============================================
+ Hits          95267    95465     +198     
+ Misses        74462    74433      -29     
  Partials       2437     2437              
Flag Coverage Δ
python 79.40% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @shunping for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@ByteFlowing1337

Copy link
Copy Markdown
Author

@shunping Do you mind reviewing this PR?
These workarounds are quite obvious; they are represented publicly in the playground examples of the Python SDK on beam.apache.org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant