Work around issue in dill for wordcount example save_main_session#7710
Merged
Conversation
Contributor
Author
|
R: @aaltay @tvalentyn @markflyhigh |
Contributor
Author
|
Run Python PostCommit |
charlesccychen
force-pushed
the
fix-wordcount-py3
branch
from
f06c5cb to
aed376e
Compare
Contributor
Author
|
Run Python PostCommit |
Contributor
|
Nice. Is it worth noting that DoFn doesn't actually have an init method, so this is not a material change? |
charlesccychen
force-pushed
the
fix-wordcount-py3
branch
from
aed376e to
415a197
Compare
Contributor
Author
|
Run Python PostCommit |
Contributor
Author
|
@robertwb Thanks, I incorporated your suggestion. |
robertwb
approved these changes
Feb 4, 2019
robertwb
left a comment
robertwb
left a comment
Contributor
There was a problem hiding this comment.
On second thought, I might just remove this whole thing, so it doesn't distract from the example. (Often the very first example people see.) You're call.
charlesccychen
force-pushed
the
fix-wordcount-py3
branch
from
415a197 to
229383a
Compare
Contributor
Author
|
Thanks, I removed it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change works around a bug in the dill library (uqfoundation/dill#300), where classes fail to unpickle in the main session if its
super()is referenced. This change modifies the wordcount example to not use such a reference.Follow this checklist to help us incorporate your contribution quickly and easily:
[BEAM-XXX] Fixes bug in ApproximateQuantiles, where you replaceBEAM-XXXwith the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.It will help us expedite review of your Pull Request if you tag someone (e.g.
@username) to look at it.Post-Commit Tests Status (on master branch)