[BEAM-12907] Run DataFrame API tests with multiple pandas versions#15587
[BEAM-12907] Run DataFrame API tests with multiple pandas versions#15587TheNeuralBit merged 3 commits intoapache:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15587 +/- ##
==========================================
- Coverage 83.51% 83.50% -0.01%
==========================================
Files 445 445
Lines 61415 61414 -1
==========================================
- Hits 51288 51285 -3
- Misses 10127 10129 +2
Continue to review full report at Codecov.
|
|
Run Whitespace PreCommit |
TheNeuralBit
force-pushed
the
test-multiple-pandas
branch
from
6566ad0 to
77ad93b
Compare
|
Run Python 3.8 PostCommit |
|
@TheNeuralBit - Is this ready for a review? |
|
Thanks for the ping, yes it is. I'll resolve the merge conflict and send it out |
TheNeuralBit
force-pushed
the
test-multiple-pandas
branch
from
77ad93b to
f911ac4
Compare
|
R: @lukecwik |
|
Run Python PreCommit |
sdks/python/tox.ini
Outdated
There was a problem hiding this comment.
Do we need to do something similar as #15693?
If not, please resolve merge and then LGTM.
There was a problem hiding this comment.
Thanks, good question. We don't in this case since we're not using -m to select tests. #15693 also added a check to make run_pytest.sh fail fast in that case.
TheNeuralBit
force-pushed
the
test-multiple-pandas
branch
from
f911ac4 to
0091204
Compare
| test.dependsOn "testPy38pandas-11" | ||
| test.dependsOn "testPy38pandas-12" | ||
| test.dependsOn "testPy38pandas-13" | ||
| (1..3).each {minor_version -> |
There was a problem hiding this comment.
nit: even though the old version had what seemed like duplicate code, it was much more code search friendly.
There was a problem hiding this comment.
Good point, I went ahead and expanded it back out (for the pyarrow ones too)
…pache#15587) * Run DataFrame API tests with multiple pandas versions * create tasks in a loop, make sure they're run in precommit * Don't define tasks in a loop
3 participants
Adds infrastructure to verify the DataFrame API with multiple pandas versions.
ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.