[BEAM-12985] Call pytest directly rather than run_pytest.sh to avoid running pyarrow tests twice#15693
Merged
TheNeuralBit merged 2 commits intoapache:masterfrom Oct 8, 2021
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15693 +/- ##
==========================================
+ Coverage 83.49% 83.50% +0.01%
==========================================
Files 445 445
Lines 61194 61194
==========================================
+ Hits 51093 51103 +10
+ Misses 10101 10091 -10
Continue to review full report at Codecov.
|
udim
approved these changes
Oct 8, 2021
sdks/python/tox.ini
Outdated
Member
There was a problem hiding this comment.
Nit: consider adding {posargs} to the end of this line. It might not be super useful in this case because I'm guessing this runs quickly, but it allows to pass additional arguments to pytest (as in: tox -e py38-pyarrow-5 -- -k my_test).
692bf04 to
3bfeebc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally, this PR adds a check to
run_pytest.shto fail early if called with-m, so we don't make this mistake in the future:ValidatesRunnercompliance status (on master branch)Examples testing status on various runners
Post-Commit SDK/Transform Integration Tests Status (on master branch)
Pre-Commit Tests Status (on master branch)
See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.