Skip to content

[BEAM-12985] Call pytest directly rather than run_pytest.sh to avoid running pyarrow tests twice#15693

Merged
TheNeuralBit merged 2 commits intoapache:masterfrom
TheNeuralBit:BEAM-12985
Oct 8, 2021
Merged

[BEAM-12985] Call pytest directly rather than run_pytest.sh to avoid running pyarrow tests twice#15693
TheNeuralBit merged 2 commits intoapache:masterfrom
TheNeuralBit:BEAM-12985

Conversation

@TheNeuralBit
Copy link
Copy Markdown
Member

Additionally, this PR adds a check to run_pytest.sh to fail early if called with -m, so we don't make this mistake in the future:

❯ ./scripts/run_pytest.sh pyarrow "-m uses_pyarrow"
./scripts/run_pytest.sh cannot be called with -m as it interferes with 'no_xdist' logic, see BEAM-12985.

ValidatesRunner compliance status (on master branch)

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- Build Status Build Status Build Status Build Status ---
Java Build Status Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Build Status
Python --- Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status ---
XLang Build Status Build Status Build Status Build Status Build Status ---

Examples testing status on various runners

Lang ULR Dataflow Flink Samza Spark Twister2
Go --- --- --- --- --- --- ---
Java --- Build Status
Build Status
Build Status
--- --- --- --- ---
Python --- --- --- --- --- --- ---
XLang --- --- --- --- --- --- ---

Post-Commit SDK/Transform Integration Tests Status (on master branch)

Go Java Python
Build Status Build Status Build Status
Build Status
Build Status

Pre-Commit Tests Status (on master branch)

--- Java Python Go Website Whitespace Typescript
Non-portable Build Status
Build Status
Build Status
Build Status
Build Status
Build Status Build Status Build Status Build Status
Portable --- Build Status Build Status --- --- ---

See .test-infra/jenkins/README for trigger phrase, status and link of all Jenkins jobs.

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@TheNeuralBit TheNeuralBit requested a review from udim October 8, 2021 16:34
@codecov
Copy link
Copy Markdown

codecov bot commented Oct 8, 2021

Codecov Report

Merging #15693 (3bfeebc) into master (cac6b50) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15693      +/-   ##
==========================================
+ Coverage   83.49%   83.50%   +0.01%     
==========================================
  Files         445      445              
  Lines       61194    61194              
==========================================
+ Hits        51093    51103      +10     
+ Misses      10101    10091      -10     
Impacted Files Coverage Δ
sdks/python/apache_beam/internal/metrics/metric.py 90.00% <0.00%> (-1.00%) ⬇️
...hon/apache_beam/runners/worker/bundle_processor.py 93.64% <0.00%> (+0.12%) ⬆️
...runners/interactive/display/pcoll_visualization.py 86.36% <0.00%> (+0.50%) ⬆️
...pache_beam/runners/interactive/interactive_beam.py 76.58% <0.00%> (+0.97%) ⬆️
...che_beam/runners/interactive/interactive_runner.py 92.59% <0.00%> (+1.85%) ⬆️
...hon/apache_beam/runners/direct/test_stream_impl.py 96.26% <0.00%> (+2.23%) ⬆️
.../python/apache_beam/testing/test_stream_service.py 93.02% <0.00%> (+4.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cac6b50...3bfeebc. Read the comment docs.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: consider adding {posargs} to the end of this line. It might not be super useful in this case because I'm guessing this runs quickly, but it allows to pass additional arguments to pytest (as in: tox -e py38-pyarrow-5 -- -k my_test).

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants