Conversation
|
Run Python 3.8 PostCommit |
|
Run Python 3.9 PostCommit |
|
Run Python 3.10 PostCommit |
|
Run Python 3.11 PostCommit |
|
Run Python_Dataframes PreCommit |
|
Run Python_PVR_Flink PreCommit |
|
Run Python_Coverage PreCommit |
|
R: @tvalentyn |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control |
|
it's not sure if this will get fixed in 1.8.5 onward, should we set upper bound version instead? |
|
Yes, I'm actually thinking about the same thing after looking at trace in fastavro/fastavro#720 |
|
I raised an issue with them. Let's see if that is included in next release. If not, we can set upper bound I think |
|
if it is a submission-runtime compatibility , rebuilding Dataflow containers to include latest fastavro version will fix it. |
|
and we don't need to change versions. |
|
but that doesn't explain why some external users got affected. i am not sure I completely understand the failure mode here. |
|
Also note that it only fails on direct and flink runner test. Dataflow running same test having no issue - so it is likely a test config issue (e.g. mismatch version) get revealed |
let's look closer into failure cause to understand it first.
Codecov Report
@@ Coverage Diff @@
## master #28871 +/- ##
==========================================
- Coverage 72.20% 72.20% -0.01%
==========================================
Files 684 685 +1
Lines 101235 101474 +239
==========================================
+ Hits 73101 73267 +166
- Misses 26558 26631 +73
Partials 1576 1576
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Scott mentioned about catching EOFError as well along with StopIteration fastavro/fastavro#720 (comment). Closing this one in favor of #28896 |
Skip fastavro 1.8.4 because of a regression caught in #28811
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.