Skip to content

Catch EOFError along with StopIteration#28896

Merged
riteshghorse merged 3 commits intoapache:masterfrom
riteshghorse:fastavro-fix
Oct 9, 2023
Merged

Catch EOFError along with StopIteration#28896
riteshghorse merged 3 commits intoapache:masterfrom
riteshghorse:fastavro-fix

Conversation

@riteshghorse
Copy link
Copy Markdown
Contributor

@riteshghorse riteshghorse commented Oct 9, 2023 •
edited
Loading

Catch EOFError along with StopIteration to align with fastavro's latest release 1.8.4
Fixes #28811

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@riteshghorse
Copy link
Copy Markdown
Contributor Author

riteshghorse commented Oct 9, 2023

Run Python 3.8 PostCommit

@riteshghorse
Copy link
Copy Markdown
Contributor Author

riteshghorse commented Oct 9, 2023

Run Python 3.9 PostCommit

@riteshghorse
Copy link
Copy Markdown
Contributor Author

riteshghorse commented Oct 9, 2023

Run Python 3.10 PostCommit

@riteshghorse
Copy link
Copy Markdown
Contributor Author

riteshghorse commented Oct 9, 2023

Run Python 3.11 PostCommit

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 9, 2023 •
edited
Loading

Codecov Report

Merging #28896 (040d1d2) into master (92d5bf8) will decrease coverage by 0.01%.
Report is 5 commits behind head on master.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #28896      +/-   ##
==========================================
- Coverage   72.23%   72.22%   -0.01%     
==========================================
  Files         685      685              
  Lines      101519   101519              
==========================================
- Hits        73330    73320      -10     
- Misses      26608    26618      +10     
  Partials     1581     1581
Flag Coverage Δ
python 82.70% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
sdks/python/apache_beam/io/gcp/bigquery.py 69.92% <0.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@riteshghorse
Copy link
Copy Markdown
Contributor Author

riteshghorse commented Oct 9, 2023

Run Python 3.9 PostCommit

@riteshghorse
Copy link
Copy Markdown
Contributor Author

riteshghorse commented Oct 9, 2023

Run Python 3.8 PostCommit

@riteshghorse
Copy link
Copy Markdown
Contributor Author

riteshghorse commented Oct 9, 2023

Run Python 3.9 PostCommit

@riteshghorse
Copy link
Copy Markdown
Contributor Author

riteshghorse commented Oct 9, 2023

Run Python_Dataframes PreCommit

@riteshghorse riteshghorse changed the title [Testing] Catch EOF instead of StopIteration Catch EOFError along with StopIteration Oct 9, 2023
@riteshghorse riteshghorse mentioned this pull request Oct 9, 2023
Closed
3 tasks
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 9, 2023

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @AnandInguva for label python.
R: @chamikaramj for label io.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@riteshghorse
Copy link
Copy Markdown
Contributor Author

riteshghorse commented Oct 9, 2023

bigquery tests are passing with this
image

@riteshghorse
Copy link
Copy Markdown
Contributor Author

riteshghorse commented Oct 9, 2023

R: @Abacn @tvalentyn

@riteshghorse riteshghorse merged commit 21f822f into apache:master Oct 9, 2023
@AnandInguva AnandInguva mentioned this pull request Oct 9, 2023
Closed
riteshghorse added a commit to riteshghorse/beam that referenced this pull request Oct 9, 2023
@riteshghorse
Catch EOFError along with StopIteration (apache#28896)
e815ad2 
* catch EOF instead of StopIteration

* add stop iteration to close

* catch both stop iteration and EOF
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 10, 2023

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control

@svetakvsundhar svetakvsundhar mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tvalentyn tvalentyn tvalentyn approved these changes

@AnandInguva AnandInguva AnandInguva approved these changes

Assignees

No one assigned

Labels

gcp io Next Action: Reviewers python

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Failing Test]: Many BigQuery direct read Python PostCommit failing possibly due to fastavro regression

3 participants

@riteshghorse @tvalentyn @AnandInguva