Skip to content

Support metrics at Source.split for Direct Runner#32022

Merged
Abacn merged 1 commit intoapache:masterfrom
Abacn:nodelete-metricsatsplit
Aug 1, 2024
Merged

Support metrics at Source.split for Direct Runner#32022
Abacn merged 1 commit intoapache:masterfrom
Abacn:nodelete-metricsatsplit

Conversation

@Abacn
Copy link
Copy Markdown
Contributor

@Abacn Abacn commented Jul 30, 2024

Address #32021 for direct runner

  • Added a validate runner test for this scenario

Please add a meaningful description for your change here

Tested manually - BUILD SUCCESSFUL for the following commands

./gradlew :runners:direct-java:validatesRunner --tests *testBoundedSourceMetricsInSplit

confirmed the new test already passing on portable runners:

./gradlew :runners:flink:1.18:job-server:validatesPortableRunnerBatch --tests *testBoundedSourceMetricsInSplit

./gradlew :runners:spark:3:job-server:validatesPortableRunnerBatch --tests *testBoundedSourceMetricsInSplit

./gradlew :runners:google-cloud-dataflow-java:validatesRunnerV2Test -PgcpProject=... -PgcpRegion=us-central1 -PgcpTempRoot=gs://.../tmp --tests *testBoundedSourceMetricsInSplit -info

Dataflow legacy runner does not support attempted metrics (and excluded it from validateRunner test). If change to match committed metrics, tested that the test also passes.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MetricKey.create has parameter type (@Nullable String, MetricName). It already supported null step

@Abacn
Copy link
Copy Markdown
Contributor Author

Abacn commented Jul 30, 2024

This will make #31804 testable on Direct runner also -- BQ source lineage were added in BoundedSource.split, currently not testable on Direct runner

* Added a validate runner test for this scenario
@Abacn Abacn force-pushed the nodelete-metricsatsplit branch from 778d47c to 9098518 Compare July 30, 2024 16:09
@Abacn
Copy link
Copy Markdown
Contributor Author

Abacn commented Jul 30, 2024

assign set of reviewers

@github-actions
Copy link
Copy Markdown
Contributor

Assigning reviewers. If you would like to opt out of this review, comment assign to next reviewer:

R: @m-trieu for label java.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@Abacn
Copy link
Copy Markdown
Contributor Author

Abacn commented Jul 31, 2024

R: @Naireen @damondouglas

@github-actions
Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

@Abacn Abacn mentioned this pull request Jul 31, 2024
3 tasks
Copy link
Copy Markdown
Contributor

@damondouglas damondouglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Abacn LGTM

@Abacn Abacn merged commit f1c72c5 into apache:master Aug 1, 2024
@Abacn Abacn deleted the nodelete-metricsatsplit branch August 1, 2024 02:00
reeba212 pushed a commit to reeba212/beam that referenced this pull request Dec 4, 2024
* Added a validate runner test for this scenario
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants