Support metrics at Source.split for Direct Runner#32022
Merged
Abacn merged 1 commit intoapache:masterfrom Aug 1, 2024
Merged
Conversation
Abacn
commented
Jul 30, 2024
Contributor
Author
There was a problem hiding this comment.
MetricKey.create has parameter type (@Nullable String, MetricName). It already supported null step
Contributor
Author
|
This will make #31804 testable on Direct runner also -- BQ source lineage were added in BoundedSource.split, currently not testable on Direct runner |
* Added a validate runner test for this scenario
778d47c to
9098518
Compare
Contributor
Author
|
assign set of reviewers |
Contributor
|
Assigning reviewers. If you would like to opt out of this review, comment R: @m-trieu for label java. Available commands:
The PR bot will only process comments in the main thread (not review comments). |
Contributor
Author
Contributor
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
3 tasks
reeba212
pushed a commit
to reeba212/beam
that referenced
this pull request
Dec 4, 2024
* Added a validate runner test for this scenario
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address #32021 for direct runner
Please add a meaningful description for your change here
Tested manually - BUILD SUCCESSFUL for the following commands
confirmed the new test already passing on portable runners:
Dataflow legacy runner does not support attempted metrics (and excluded it from validateRunner test). If change to match committed metrics, tested that the test also passes.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.