Conversation
|
tested on integration test (rebased on #32022) PubsubReadIT: after get PubsubWriteIT: replace to use |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
rohitsinha54
left a comment
There was a problem hiding this comment.
Would it be possible to update any of the PubSub integration tests which runs in dataflow runner to assert for lineage metrics?
|
We can and should do this after runner support cleared. currently Pubsub integration tests are running on both direct runner / legacy Dataflow / Dataflow v2. When I add asserts currently it will only pass on Legacy runner suite (Direct runner suite will also pass after #32022 in) |
|
a couple of unit tests failed due to that the fake topic/subscription does not follow the expected topic/subscription format, direct runner integration tests all passed however |
* Add Lineage metrics to PubsubIO * fix format and add test * make getDatacatalogname fail safe
Covers
UnboundedReader
PubsubBoundedWriter
PubsubUnboundedWriter (PubsubSink / PubsubDynamicSink)
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.