Upgrade expansion jar to java17#38931
Conversation
derrickaw
changed the title
derrickaw
force-pushed
the
20260611_upgradeExponsionJarToJava17
branch
from
19d21e0 to
6bcab53
Compare
|
io-expansion-service container is still on Java 11 runtime: We need to bump to Java17 And also all other gradle targets and its tests consumed io-expansion-service would need to bump Java version as well |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Java version requirement for the expansion service and its associated build processes to Java 17. This change is necessary to accommodate dependencies that require a newer Java runtime, ensuring compatibility and stability for cross-language and Java-specific workflows. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Java version from 11 to 17 for the expansion service container and build configuration (due to Delta Lake requirements), and conditionally sets the Java version to 17 in the GitHub setup-environment action for specific jobs. The review feedback suggests avoiding hardcoded job name patterns in the shared GitHub action and instead passing the Java version as an input parameter to improve modularity and maintainability.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| with: | ||
| distribution: 'temurin' | ||
| java-version: ${{ inputs.java-version == 'default' && '11' || inputs.java-version }} | ||
| java-version: ${{ inputs.java-version == 'default' && ((contains(github.job, 'Xlang') || contains(github.job, 'XVR') || contains(github.job, 'PreCommit_Java')) && '17' || '11') || inputs.java-version }} |
There was a problem hiding this comment.
Hardcoding specific job name patterns (like 'Xlang', 'XVR', and 'PreCommit_Java') inside a shared action reduces its modularity and maintainability. If new jobs require Java 17 or existing jobs are renamed, this action will need to be constantly updated. Instead of inspecting github.job inside the action, consider passing the appropriate java-version (e.g., '17') as an input parameter directly from the calling workflow files.
There was a problem hiding this comment.
This is a valid comment and it indeed caused a couple of tests now failing
We should keep Java artifacts compiled on Java11 by default as it matches release build
|
Assigning reviewers: R: @chamikaramj for label java. Note: If you would like to opt out of this review, comment Available commands:
The PR bot will only process comments in the main thread (not review comments). |
* upgrade expansion sevice to Java 17 * update comment * add container and workflow change * try something * Add PreCommit_Java to run on Java 17 in setup-environment-action * add more coverage
This reverts commit b3a62ee.
* upgrade expansion sevice to Java 17 * update comment * add container and workflow change * try something * Add PreCommit_Java to run on Java 17 in setup-environment-action * add more coverage
This reverts commit b3a62ee.
2 participants
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.