Skip to content

Revert "Upgrade expansion jar to java17"#38965

Merged
derrickaw merged 1 commit into
masterfrom
revert-38931-20260611_upgradeExponsionJarToJava17
Jun 15, 2026
Merged

Revert "Upgrade expansion jar to java17"#38965
derrickaw merged 1 commit into
masterfrom
revert-38931-20260611_upgradeExponsionJarToJava17

Conversation

@Abacn

@Abacn Abacn commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Reverts #38931

Fix InaccessibleObjectException seen in presubmit tests

When rolling forward, do not change the default in setup-environment action but use java_version: 17 11 in individual tests, like what we did in https://github.com/apache/beam/pull/35232/changes#diff-4eb1051f5356e9447cc88403c921bc6b329d5f34a3ca02325b253515bce9dec4

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request reverts a previous upgrade to Java 17 for the expansion service. The change is intended to address compatibility issues, specifically InaccessibleObjectException, encountered during presubmit testing. Future updates to Java 17 will be handled on a per-test basis rather than as a global default.

Highlights

  • Java Version Reversion: Reverted the default Java version from 17 back to 11 in the setup-environment action to resolve InaccessibleObjectException errors in presubmit tests.
  • Container Image Update: Updated the expansion service Dockerfile to use eclipse-temurin:11 instead of 17.
  • Build Configuration: Updated the expansion service build configuration to require Java 11 instead of 17.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/beam_PreCommit_Xlang_Generated_Transforms.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request downgrades the Java version from 17 to 11 across several configurations, including the GitHub Actions setup environment action, the expansion service Dockerfile, and the Java IO expansion service build configuration. I have no feedback to provide as there are no review comments.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @chamikaramj for label java.
R: @liferoad for label build.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

@derrickaw derrickaw merged commit 98e29d9 into master Jun 15, 2026
31 checks passed
@Abacn Abacn deleted the revert-38931-20260611_upgradeExponsionJarToJava17 branch June 15, 2026 17:59
ash6898 pushed a commit to ash6898/beam that referenced this pull request Jun 28, 2026
ash6898 pushed a commit to ash6898/beam that referenced this pull request Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants