Skip to content

Upgrade ZooKeeper dependency to 3.8.0 - gradle - #3084

Closed
eolivelli wants to merge 4 commits into
apache:masterfrom
eolivelli:impl/upgrade-zookeeper-380
Closed

Upgrade ZooKeeper dependency to 3.8.0 - gradle#3084
eolivelli wants to merge 4 commits into
apache:masterfrom
eolivelli:impl/upgrade-zookeeper-380

Conversation

@eolivelli

Copy link
Copy Markdown
Contributor

Motivation

We are using an old version of ZooKeeper, 3.6.x (and ZooKeeper 3.5.x was declared EOL a few weeks ago).
We should upgrade to the latest version.

Changes

Upgraded ZooKeeper dependency.

@nicoloboschi nicoloboschi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should also update the backward compatibilty tests

@dlg99

dlg99 commented Mar 9, 2022

Copy link
Copy Markdown
Contributor

License check failed, OWASP detects new CVEs in zk 3.8 (are these real or misdetections?) + test failures.
These have to be addressed.

@eolivelli

Copy link
Copy Markdown
Contributor Author

@dlg99

regarding OWASP we can follow this discussion
apache/pulsar#14630

basically there are false positives about "Jetty" that the OWASP checker reports in zookeeper jars

in ZooKeeper project we added these exclusions
apache/zookeeper@3004c90

Regarding the LICENSE check...my Gradle Fu is very weak and I am not able to tell Gradle to fully exclude LogBack and fix the package.

Any suggestion is really appreciated

@dlg99

dlg99 commented Mar 11, 2022

Copy link
Copy Markdown
Contributor

You can suppress false positives at https://github.com/apache/bookkeeper/blob/master/src/owasp-dependency-check-suppressions.xml

As for the logback, try something like

configurations {
  runtime.exclude group: "......", module: "....."
}

or

configurations {
  all.exclude group: "......", module: "....."
}

Search for "configurations" in the build.gradle

Maybe @lhotari knows a better way

@eolivelli

Copy link
Copy Markdown
Contributor Author

@dlg99 thanks for your advice but I cannot make it work

I hope that some Gradle expert could help
@pkumar-singh @lhotari @nicoloboschi

@eolivelli eolivelli changed the title Upgrade ZooKeeper dependency to 3.8.0 Upgrade ZooKeeper dependency to 3.8.0 - gradle Mar 27, 2022
@eolivelli eolivelli closed this Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants