Upgrade ZooKeeper to 3.8.0 - #3145
Merged
Merged
Conversation
nicoloboschi
requested changes
Mar 27, 2022
nicoloboschi
left a comment
nicoloboschi
left a comment
Contributor
There was a problem hiding this comment.
Can you add owasp suppressions?
Contributor
Author
sure, I was just working on that |
eolivelli
force-pushed
the
impl/zookeeper-380-maven
branch
from
March 27, 2022 12:46
6455a35 to
15ed7fd
Compare
dlg99
approved these changes
Mar 28, 2022
nicoloboschi
requested changes
Mar 28, 2022
nicoloboschi
left a comment
nicoloboschi
left a comment
Contributor
There was a problem hiding this comment.
good job! I left one comment about commons-compress downgrade
eolivelli
force-pushed
the
impl/zookeeper-380-maven
branch
from
March 28, 2022 08:29
5eefe17 to
0c9e8d4
Compare
eolivelli
force-pushed
the
impl/zookeeper-380-maven
branch
from
March 28, 2022 15:53
0c9e8d4 to
554bd4e
Compare
Contributor
Author
|
the failed test passes locally on my laptop |
eolivelli
added
area/metadata
dependencies
nicoloboschi
approved these changes
Mar 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
We are using an old version of ZooKeeper, 3.6.x (and ZooKeeper 3.5.x was declared EOL a few weeks ago).
We should upgrade to the latest version.
Changes
Notes
In PR #3084 I tried to update ZooKeeper in Gradle files, but without success.
This patch focuses only on Maven