Skip to content

BookieAutoRecoveryTest.testEmptyLedgerLosesQuorumEventually fix flaky test, ensure that the Auditor is alive - #3149

Merged
eolivelli merged 3 commits into
apache:masterfrom
eolivelli:tests/flaky-replication-test
Mar 28, 2022
Merged

BookieAutoRecoveryTest.testEmptyLedgerLosesQuorumEventually fix flaky test, ensure that the Auditor is alive#3149
eolivelli merged 3 commits into
apache:masterfrom
eolivelli:tests/flaky-replication-test

Conversation

@eolivelli

@eolivelli eolivelli commented Mar 28, 2022

Copy link
Copy Markdown
Contributor

Motivation

The test testEmptyLedgerLosesQuorumEventually kills two bookies, and very often it kills the Auditor Bookie.

Changes

  • BookKeeperClusterTestCase.getAuditor(), ensure that we pick up a Auditor that is running and that is not going to die soon
  • ReplicationWorker exits the main loop in case of InterruptedException masked by a UnavailableException (this reduces a lot the spam in the logs, because in any case the thread is deemed to always fail for InterruptedExceptions)
  • in testEmptyLedgerLosesQuorumEventually ensure that the Auditor runs and start a new Bookie before the final check (the Auditor does nothing if the is no "bookie to audit", so there are races in which if the cluster does not change the Auditor does not kick in in any case)

@eolivelli
eolivelli force-pushed the tests/flaky-replication-test branch from d63ed72 to 4c8591a Compare March 28, 2022 08:23
@eolivelli
eolivelli requested a review from dlg99 March 28, 2022 10:53
@eolivelli
eolivelli merged commit dc2eafa into apache:master Mar 28, 2022
@eolivelli
eolivelli deleted the tests/flaky-replication-test branch March 28, 2022 15:57
hangc0276 pushed a commit to hangc0276/bookkeeper that referenced this pull request Nov 7, 2022
… test, ensure that the Auditor is alive (apache#3149)

(cherry picked from commit dc2eafa)
hangc0276 pushed a commit to hangc0276/bookkeeper that referenced this pull request Nov 7, 2022
… test, ensure that the Auditor is alive (apache#3149)

(cherry picked from commit dc2eafa)
nicoloboschi pushed a commit to datastax/bookkeeper that referenced this pull request Jan 11, 2023
… test, ensure that the Auditor is alive (apache#3149)

(cherry picked from commit dc2eafa)
(cherry picked from commit d4c4e21)
Ghatage pushed a commit to sijie/bookkeeper that referenced this pull request Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants