Fix serious Performance problem of getLastEntryInLedgerInternal - #3769
Closed
gaozhangmin wants to merge 1 commit into
Closed
Fix serious Performance problem of getLastEntryInLedgerInternal#3769gaozhangmin wants to merge 1 commit into
gaozhangmin wants to merge 1 commit into
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3769 +/- ##
=============================================
- Coverage 68.02% 32.49% -35.54%
+ Complexity 6659 3058 -3601
=============================================
Files 468 468
Lines 40844 40848 +4
Branches 5235 5236 +1
=============================================
- Hits 27786 13275 -14511
- Misses 10807 25898 +15091
+ Partials 2251 1675 -576
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes #3239
Search the last entry in storage would be time consume if ledger is empty and RocksDB database is huge.
Changes
Check if the ledger is empty first.