Skip to content

Fix serious Performance problem of getLastEntryInLedgerInternal #3769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gaozhangmin wants to merge 1 commit into from
Closed

Fix serious Performance problem of getLastEntryInLedgerInternal #3769

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...per-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/EntryLocationIndex.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,14 @@ public long getLastEntryInLedger(long ledgerId) throws IOException {
}

private long getLastEntryInLedgerInternal(long ledgerId) throws IOException {
// Search the last entry in storage would be time consume in the case of empty ledger.
// check if ledge is empty first.
long entryLocation = getLocation(ledgerId, 0);
if (entryLocation == 0) {
log.warn("Tried to get last entry from an empty ledger: {}", ledgerId);
throw new Bookie.NoEntryException(ledgerId, -1);
}

LongPairWrapper maxEntryId = LongPairWrapper.get(ledgerId, Long.MAX_VALUE);

// Search the last entry in storage
Expand Down