[fix](mow) reduce mow delete bitmap count: agg and remove delete bitmap of pre rowsets when cu compaction#49383
Merged
Merged
Conversation
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 34480 ms |
TPC-DS: Total hot run time: 194000 ms |
ClickBench: Total hot run time: 31.14 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
mymeiyi
force-pushed
the
delete-dm
branch
2 times, most recently
from
2643fe4 to
2c5da11
Compare
Contributor
Author
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 34206 ms |
TPC-DS: Total hot run time: 192722 ms |
ClickBench: Total hot run time: 31.79 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
mymeiyi
force-pushed
the
delete-dm
branch
2 times, most recently
from
6a68198 to
9a434ec
Compare
Contributor
Author
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 34384 ms |
TPC-DS: Total hot run time: 186397 ms |
ClickBench: Total hot run time: 31.18 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run buildall |
|
TeamCity cloud ut coverage result: |
TPC-H: Total hot run time: 34483 ms |
TPC-DS: Total hot run time: 194753 ms |
ClickBench: Total hot run time: 31.74 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-DS: Total hot run time: 185815 ms |
ClickBench: Total hot run time: 29.31 s |
Contributor
|
run buildall |
zhannngchen
approved these changes
May 26, 2025
github-actions
Bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 33972 ms |
TPC-DS: Total hot run time: 193320 ms |
ClickBench: Total hot run time: 29.8 s |
Contributor
|
run buildall |
Contributor
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 33570 ms |
TPC-DS: Total hot run time: 186221 ms |
ClickBench: Total hot run time: 29.34 s |
koarz
pushed a commit
to koarz/doris
that referenced
this pull request
Jun 4, 2025
…ap of pre rowsets when cu compaction (apache#49383) ### What problem does this PR solve? This PR reduce delete bitmap count of mow tables #### Basic idea 1. when do cumulative compaction [start_rowset, end_rowset], which version is [start_version, end_version] 2. agg pre_rowsets'(version less than start_version) delete bitmap between [start_version, end_version] to end_version, 3. when all of the rowsets of [start_rowset, end_rowset] are deleted, delete pre rowsets' delete bitmap between [start_version, end_version). #### One example suppose the rowset and delete bitmap layout is: ``` [rowset_id]: [delete bitmap] r1-3: v6, v7, v8, v9 r4-6: v7, v8, v9 r7: v8, v9 r8: v9 r9: ``` if do cumulative compaction for {r7, r8, r9} before this pr, the delete bitmap layout is (there is 7 delete bitmap left): ``` [rowset_id]: [delete bitmap] r1-3: v6, v7, v8, v9 r4-6: v7, v8, v9 r7-9: ``` after this pr (there is 3 delete bitmap left): ``` [rowset_id]: [delete bitmap] r1-3: v6, new_v9 // new_v9 is agged by the previous v7, v8, v9 of r1-3 r4-6: new_v9 // new_v9 is agged by the previous v7, v8, v9 of r4-6 r7-9: ``` #### The implementation of local mode ##### delete bitmap in BE memory 1. agged when delete stale rowset path 2. removed when delete unused rowsets ##### delete bitmap in BE local storage `save_meta` to store delete bitmap after remove unused rowsets related delete bitmap #### The implementation of cloud mode ##### delete bitmap in BE memory 1. agged when delete stale rowset path 2. removed when delete unused rowsets ##### delete bitmap in Meta Service 1. agged when finish compaction 2. send `update_delete_bitmap` to ms to modify and remove pre rowsets delete bitmap ### Release note None
dataroaring
pushed a commit
that referenced
this pull request
Jun 10, 2025
### What problem does this PR solve? now, the delete bitmap is removed when move stale rowsets to unused rowsets, but if some queries is still read the stale rowsets, the query result may get duplicated keys. this pr change the remove of delete bitmap when remove unused rowsets. this pr is based on #49383
mymeiyi
added a commit
to mymeiyi/doris
that referenced
this pull request
Jun 24, 2025
…ap of pre rowsets when cu compaction (apache#49383) This PR reduce delete bitmap count of mow tables 1. when do cumulative compaction [start_rowset, end_rowset], which version is [start_version, end_version] 2. agg pre_rowsets'(version less than start_version) delete bitmap between [start_version, end_version] to end_version, 3. when all of the rowsets of [start_rowset, end_rowset] are deleted, delete pre rowsets' delete bitmap between [start_version, end_version). suppose the rowset and delete bitmap layout is: ``` [rowset_id]: [delete bitmap] r1-3: v6, v7, v8, v9 r4-6: v7, v8, v9 r7: v8, v9 r8: v9 r9: ``` if do cumulative compaction for {r7, r8, r9} before this pr, the delete bitmap layout is (there is 7 delete bitmap left): ``` [rowset_id]: [delete bitmap] r1-3: v6, v7, v8, v9 r4-6: v7, v8, v9 r7-9: ``` after this pr (there is 3 delete bitmap left): ``` [rowset_id]: [delete bitmap] r1-3: v6, new_v9 // new_v9 is agged by the previous v7, v8, v9 of r1-3 r4-6: new_v9 // new_v9 is agged by the previous v7, v8, v9 of r4-6 r7-9: ``` 1. agged when delete stale rowset path 2. removed when delete unused rowsets `save_meta` to store delete bitmap after remove unused rowsets related delete bitmap 1. agged when delete stale rowset path 2. removed when delete unused rowsets 1. agged when finish compaction 2. send `update_delete_bitmap` to ms to modify and remove pre rowsets delete bitmap None
mymeiyi
added a commit
to mymeiyi/doris
that referenced
this pull request
Jun 24, 2025
…ap of pre rowsets when cu compaction (apache#49383) This PR reduce delete bitmap count of mow tables 1. when do cumulative compaction [start_rowset, end_rowset], which version is [start_version, end_version] 2. agg pre_rowsets'(version less than start_version) delete bitmap between [start_version, end_version] to end_version, 3. when all of the rowsets of [start_rowset, end_rowset] are deleted, delete pre rowsets' delete bitmap between [start_version, end_version). suppose the rowset and delete bitmap layout is: ``` [rowset_id]: [delete bitmap] r1-3: v6, v7, v8, v9 r4-6: v7, v8, v9 r7: v8, v9 r8: v9 r9: ``` if do cumulative compaction for {r7, r8, r9} before this pr, the delete bitmap layout is (there is 7 delete bitmap left): ``` [rowset_id]: [delete bitmap] r1-3: v6, v7, v8, v9 r4-6: v7, v8, v9 r7-9: ``` after this pr (there is 3 delete bitmap left): ``` [rowset_id]: [delete bitmap] r1-3: v6, new_v9 // new_v9 is agged by the previous v7, v8, v9 of r1-3 r4-6: new_v9 // new_v9 is agged by the previous v7, v8, v9 of r4-6 r7-9: ``` 1. agged when delete stale rowset path 2. removed when delete unused rowsets `save_meta` to store delete bitmap after remove unused rowsets related delete bitmap 1. agged when delete stale rowset path 2. removed when delete unused rowsets 1. agged when finish compaction 2. send `update_delete_bitmap` to ms to modify and remove pre rowsets delete bitmap None
mymeiyi
added a commit
to mymeiyi/doris
that referenced
this pull request
Jun 24, 2025
…ap of pre rowsets when cu compaction (apache#49383) This PR reduce delete bitmap count of mow tables 1. when do cumulative compaction [start_rowset, end_rowset], which version is [start_version, end_version] 2. agg pre_rowsets'(version less than start_version) delete bitmap between [start_version, end_version] to end_version, 3. when all of the rowsets of [start_rowset, end_rowset] are deleted, delete pre rowsets' delete bitmap between [start_version, end_version). suppose the rowset and delete bitmap layout is: ``` [rowset_id]: [delete bitmap] r1-3: v6, v7, v8, v9 r4-6: v7, v8, v9 r7: v8, v9 r8: v9 r9: ``` if do cumulative compaction for {r7, r8, r9} before this pr, the delete bitmap layout is (there is 7 delete bitmap left): ``` [rowset_id]: [delete bitmap] r1-3: v6, v7, v8, v9 r4-6: v7, v8, v9 r7-9: ``` after this pr (there is 3 delete bitmap left): ``` [rowset_id]: [delete bitmap] r1-3: v6, new_v9 // new_v9 is agged by the previous v7, v8, v9 of r1-3 r4-6: new_v9 // new_v9 is agged by the previous v7, v8, v9 of r4-6 r7-9: ``` 1. agged when delete stale rowset path 2. removed when delete unused rowsets `save_meta` to store delete bitmap after remove unused rowsets related delete bitmap 1. agged when delete stale rowset path 2. removed when delete unused rowsets 1. agged when finish compaction 2. send `update_delete_bitmap` to ms to modify and remove pre rowsets delete bitmap None
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR reduce delete bitmap count of mow tables
Basic idea
One example
suppose the rowset and delete bitmap layout is:
if do cumulative compaction for {r7, r8, r9}
before this pr, the delete bitmap layout is (there is 7 delete bitmap left):
after this pr (there is 3 delete bitmap left):
The implementation of local mode
delete bitmap in BE memory
delete bitmap in BE local storage
save_metato store delete bitmap after remove unused rowsets related delete bitmapThe implementation of cloud mode
delete bitmap in BE memory
delete bitmap in Meta Service
update_delete_bitmapto ms to modify and remove pre rowsets delete bitmapRelease note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)