[fix](mow) remove delete bitmap when remove unused rowsets#50973
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
99861a4 to
b61a0d4
Compare
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 33516 ms |
TPC-DS: Total hot run time: 192162 ms |
ClickBench: Total hot run time: 29.84 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
b61a0d4 to
4b31c15
Compare
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 34029 ms |
TPC-DS: Total hot run time: 187204 ms |
ClickBench: Total hot run time: 28.64 s |
90cacd7 to
793d140
Compare
|
run buildall |
TPC-H: Total hot run time: 33799 ms |
TPC-DS: Total hot run time: 185465 ms |
ClickBench: Total hot run time: 29.36 s |
793d140 to
d7dda3e
Compare
|
run buildall |
TPC-H: Total hot run time: 35039 ms |
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
| << "tablet_id=" << tablet_id() | ||
| << ", rowset_id=" << rs->rowset_id().to_string() | ||
| << ", existed rowset=" << find_it->second->rowset_id().to_string(); | ||
| _unused_rowsets.emplace(find_it->second->rowset_id(), find_it->second); |
There was a problem hiding this comment.
does here need std::lock_guard < std::mutex > lock(_gc_mutex);?
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
What problem does this PR solve?
now, the delete bitmap is removed when move stale rowsets to unused rowsets, but if some queries is still read the stale rowsets, the query result may get duplicated keys.
this pr change the remove of delete bitmap when remove unused rowsets.
this pr is based on #49383
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)