Skip to content

branch-3.1: [fix](mow) remove delete bitmap when remove unused rowsets (#50973)#52180

Merged
morrySnow merged 1 commit into
apache:branch-3.1from
mymeiyi:3.1-pick-50973
Jun 24, 2025
Merged

branch-3.1: [fix](mow) remove delete bitmap when remove unused rowsets (#50973)#52180
morrySnow merged 1 commit into
apache:branch-3.1from
mymeiyi:3.1-pick-50973

Conversation

@mymeiyi

@mymeiyi mymeiyi commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

pick #50973

@mymeiyi mymeiyi requested a review from morrySnow as a code owner June 24, 2025 03:39
@Thearas

Thearas commented Jun 24, 2025

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mymeiyi

mymeiyi commented Jun 24, 2025

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

Copy link
Copy Markdown
TPC-H: Total hot run time: 39897 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a16cabf546a422a54b2fba00596eacd0efbea394, data reload: false

------ Round 1 ----------------------------------
q1	17571	6917	6671	6671
q2	3004	171	162	162
q3	11945	1333	1183	1183
q4	10297	747	703	703
q5	7755	2862	2864	2862
q6	209	133	134	133
q7	973	629	620	620
q8	9363	1949	2041	1949
q9	6673	6449	6434	6434
q10	6979	2300	2263	2263
q11	464	259	263	259
q12	394	209	213	209
q13	17772	3021	2961	2961
q14	232	207	203	203
q15	502	472	467	467
q16	486	377	378	377
q17	977	647	601	601
q18	7545	6677	6763	6677
q19	1329	972	899	899
q20	471	193	212	193
q21	4082	3222	3107	3107
q22	1088	964	1027	964
Total cold run time: 110111 ms
Total hot run time: 39897 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6743	6553	6618	6553
q2	325	236	230	230
q3	2892	2853	3003	2853
q4	2158	1819	1757	1757
q5	5712	5709	5703	5703
q6	212	126	128	126
q7	2191	1794	1728	1728
q8	3355	3499	3515	3499
q9	8864	8806	8845	8806
q10	3593	3570	3569	3569
q11	596	496	490	490
q12	810	604	598	598
q13	7819	3154	3136	3136
q14	288	272	257	257
q15	499	471	467	467
q16	479	431	418	418
q17	1827	1587	1599	1587
q18	8244	7784	7789	7784
q19	1706	1493	1509	1493
q20	2120	1872	1876	1872
q21	4974	4823	4769	4769
q22	1107	987	963	963
Total cold run time: 66514 ms
Total hot run time: 58658 ms

@doris-robot

Copy link
Copy Markdown
TPC-DS: Total hot run time: 190443 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a16cabf546a422a54b2fba00596eacd0efbea394, data reload: false

query1	995	379	362	362
query2	6524	1937	1920	1920
query3	6703	211	218	211
query4	34039	23400	23389	23389
query5	4265	451	440	440
query6	272	188	180	180
query7	4639	311	322	311
query8	309	229	228	228
query9	9739	2587	2565	2565
query10	485	259	252	252
query11	18078	15190	15202	15190
query12	152	101	99	99
query13	1632	411	401	401
query14	8814	7166	6617	6617
query15	234	171	169	169
query16	8030	492	467	467
query17	1625	565	568	565
query18	2116	301	311	301
query19	224	161	160	160
query20	114	106	107	106
query21	207	101	102	101
query22	4445	4197	4381	4197
query23	33975	34181	33966	33966
query24	11032	2850	2892	2850
query25	684	423	417	417
query26	1526	168	173	168
query27	3000	363	344	344
query28	8016	2129	2130	2129
query29	996	445	443	443
query30	326	160	154	154
query31	1007	768	769	768
query32	102	61	61	61
query33	793	303	301	301
query34	955	519	530	519
query35	860	693	714	693
query36	1109	960	948	948
query37	138	69	68	68
query38	3925	3801	3822	3801
query39	1485	1450	1423	1423
query40	292	101	103	101
query41	53	50	51	50
query42	118	99	103	99
query43	512	494	478	478
query44	1297	804	802	802
query45	183	168	167	167
query46	1159	742	757	742
query47	1906	1819	1857	1819
query48	446	344	353	344
query49	1241	425	416	416
query50	819	417	419	417
query51	7374	7169	7208	7169
query52	102	96	88	88
query53	254	184	187	184
query54	1310	467	461	461
query55	77	80	78	78
query56	270	258	254	254
query57	1322	1150	1155	1150
query58	250	227	241	227
query59	3207	2950	2868	2868
query60	289	260	270	260
query61	140	143	159	143
query62	849	661	685	661
query63	214	191	203	191
query64	5261	632	648	632
query65	3303	3178	3186	3178
query66	1456	307	307	307
query67	15969	15579	15431	15431
query68	4691	573	581	573
query69	449	272	259	259
query70	1163	1089	1081	1081
query71	421	262	260	260
query72	6467	4085	4169	4085
query73	765	351	362	351
query74	10314	9007	9136	9007
query75	3398	2630	2640	2630
query76	3019	1131	1040	1040
query77	463	276	268	268
query78	10434	9710	9547	9547
query79	1476	590	595	590
query80	1046	443	422	422
query81	530	221	219	219
query82	929	91	87	87
query83	210	144	138	138
query84	238	78	83	78
query85	1317	313	298	298
query86	380	294	308	294
query87	4378	4265	4257	4257
query88	3570	2401	2356	2356
query89	409	299	289	289
query90	1935	193	187	187
query91	143	107	113	107
query92	57	50	53	50
query93	1074	543	541	541
query94	884	304	293	293
query95	352	261	255	255
query96	607	277	292	277
query97	3315	3130	3168	3130
query98	214	212	197	197
query99	1511	1347	1276	1276
Total cold run time: 299402 ms
Total hot run time: 190443 ms

@doris-robot

Copy link
Copy Markdown
ClickBench: Total hot run time: 29.36 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a16cabf546a422a54b2fba00596eacd0efbea394, data reload: false

query1	0.04	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.06
query4	1.62	0.10	0.11
query5	0.51	0.48	0.52
query6	1.13	0.73	0.74
query7	0.02	0.02	0.01
query8	0.04	0.03	0.03
query9	0.56	0.51	0.50
query10	0.55	0.55	0.56
query11	0.17	0.11	0.10
query12	0.14	0.11	0.11
query13	0.60	0.60	0.60
query14	0.78	0.78	0.80
query15	0.84	0.83	0.82
query16	0.38	0.38	0.40
query17	1.07	1.01	1.00
query18	0.24	0.22	0.23
query19	1.97	1.87	1.90
query20	0.01	0.01	0.01
query21	15.40	0.60	0.60
query22	2.26	2.66	1.55
query23	17.06	0.96	0.85
query24	3.49	0.37	0.95
query25	0.25	0.18	0.09
query26	0.36	0.13	0.13
query27	0.04	0.06	0.05
query28	10.64	0.51	0.50
query29	12.58	3.17	3.19
query30	0.25	0.07	0.07
query31	2.84	0.40	0.38
query32	3.24	0.46	0.45
query33	2.95	2.98	2.98
query34	16.95	4.43	4.46
query35	4.54	4.57	4.57
query36	0.66	0.46	0.47
query37	0.08	0.06	0.06
query38	0.05	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.12	0.13
query41	0.08	0.02	0.03
query42	0.03	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.93 s
Total hot run time: 29.36 s

@hello-stephen

Copy link
Copy Markdown
Contributor

BE UT Coverage Report

Increment line coverage 1.01% (2/198) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.33% (10963/26524)
Line Coverage 32.18% (94196/292693)
Region Coverage 31.26% (48582/155391)
Branch Coverage 27.94% (25082/89760)

@morrySnow morrySnow merged commit ae53bac into apache:branch-3.1 Jun 24, 2025
22 of 23 checks passed
@mymeiyi mymeiyi deleted the 3.1-pick-50973 branch September 10, 2025 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants