Skip to content

[opt](inverted index) default index format uses v3#57252

Merged
yiguolei merged 1 commit into
apache:branch-4.0from
zzzxl1993:202510231040
Oct 23, 2025
Merged

[opt](inverted index) default index format uses v3#57252
yiguolei merged 1 commit into
apache:branch-4.0from
zzzxl1993:202510231040

Conversation

@zzzxl1993

@zzzxl1993 zzzxl1993 commented Oct 23, 2025

Copy link
Copy Markdown
Contributor

@zzzxl1993 zzzxl1993 requested a review from yiguolei as a code owner October 23, 2025 02:47
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zzzxl1993

Copy link
Copy Markdown
Contributor Author

run buildall

@doris-robot

Copy link
Copy Markdown
ClickBench: Total hot run time: 31.77 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit cbaa491206834582373dcfe7859e45ed0311e6ab, data reload: true

query1	0.04	0.04	0.04
query2	0.12	0.05	0.04
query3	0.25	0.08	0.08
query4	1.63	0.11	0.12
query5	0.28	0.26	0.27
query6	1.19	0.68	0.66
query7	0.04	0.02	0.03
query8	0.07	0.04	0.04
query9	0.66	0.55	0.54
query10	0.59	0.59	0.60
query11	0.17	0.11	0.11
query12	0.16	0.12	0.13
query13	0.65	0.61	0.62
query14	0.82	0.86	0.84
query15	0.89	0.88	0.89
query16	0.41	0.40	0.41
query17	1.06	1.09	1.11
query18	0.19	0.19	0.20
query19	2.00	1.88	1.90
query20	0.02	0.01	0.02
query21	15.40	1.00	0.60
query22	0.79	1.26	0.86
query23	14.86	1.43	0.64
query24	16.32	1.54	0.64
query25	2.18	0.44	0.21
query26	0.20	0.20	0.20
query27	0.22	0.22	0.21
query28	1.75	1.09	0.97
query29	12.77	4.13	3.48
query30	0.30	0.13	0.10
query31	2.89	0.64	0.39
query32	3.25	0.58	0.50
query33	3.05	3.22	3.15
query34	16.48	5.56	5.15
query35	5.05	5.21	5.20
query36	0.73	0.59	0.57
query37	0.11	0.08	0.07
query38	0.07	0.06	0.05
query39	0.04	0.03	0.03
query40	0.20	0.16	0.15
query41	0.09	0.03	0.04
query42	0.04	0.02	0.02
query43	0.05	0.04	0.04
Total cold run time: 108.08 s
Total hot run time: 31.77 s

@yiguolei yiguolei merged commit 3c29034 into apache:branch-4.0 Oct 23, 2025
28 of 29 checks passed
morningman added a commit that referenced this pull request Jun 22, 2026
…eplica_compaction_with_format_v2 to V3 default (#64666)

## Proposed changes

Fix two pre-existing branch-4.0 P0 regression-test failures (surfaced by
an internal P0 build). Both are test-side issues, unrelated to product
code.

### 1. `test_single_replica_compaction_with_format_v2` — failed 100% on
master/4.1/4.0, passes on 3.0

`#57252` changed the FE default `inverted_index_storage_format` from
`V2` to `V3`, but this test still created its table without pinning the
property and asserted `check_nested_index_file(..., 2, 3, "V2")` with a
hardcoded rowset count. Its sibling `*_format_v2` tests
(`test_cumulative_compaction_with_format_v2`,
`test_mow_table_with_format_v2`) were already migrated to a dynamic
rowset count + `"V3"`; this one was missed.

Fix: derive the post-compaction rowset count per tablet via
`be_show_tablet_status` and assert `"V3"`, mirroring the sibling tests.

### 2. `test_curd_wlg` — flaky

The `bypass_group` (`max_concurrency=0`) check expects `select count(1)
from wlg_test_table` to be rejected with `query waiting queue is full`.
That identical query is run repeatedly earlier in the suite, so it can
be served from the FE SQL result cache, which returns before a
Coordinator is built and never enters the query queue — so the rejection
never fires and the assertion sees no exception (`but meet 'null'`).

Fix: disable the SQL cache (`set enable_sql_cache=false`) around this
assertion so the query actually executes and hits the queue, then
restore it.

## Further comments

Test-only changes. Cannot be verified locally (needs a deployed cluster
with >= 2 BEs); please verify via CI.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants