branch-4.0: [fix](test) deflake test_curd_wlg and adapt test_single_replica_compaction_with_format_v2 to V3 default#64666
Merged
morningman merged 1 commit intoJun 22, 2026
Conversation
…_with_format_v2 to V3 default Two pre-existing test failures surfaced by branch-4.0 P0 (TC build 198906), both unrelated to the commit the pipeline ran on. 1) test_single_replica_compaction_with_format_v2 (failed 100% on master/4.1/4.0, passes on 3.0): apache#57252 changed the FE default inverted_index_storage_format from V2 to V3, but this test still hardcoded `check_nested_index_file(..., 2, 3, "V2")`. Its sibling format_v2 tests (cumulative / mow_table) were already migrated to a dynamic rowset count + "V3"; this one was missed. Derive the post-compaction rowset count per tablet via be_show_tablet_status and assert V3. 2) test_curd_wlg (flaky): the bypass_group (max_concurrency=0) assertion expects `select count(1) from wlg_test_table` to be rejected with "query waiting queue is full". That identical query is run repeatedly in the suite, so it can be served from the FE SQL result cache, which returns before building a Coordinator and never enters the query queue -> no rejection -> "but meet 'null'". Disable the SQL cache around this assertion so the query actually executes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CznUqKGNmRkCrYnks7SnWA
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
hello-stephen
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fix two pre-existing branch-4.0 P0 regression-test failures (surfaced by an internal P0 build). Both are test-side issues, unrelated to product code.
1.
test_single_replica_compaction_with_format_v2— failed 100% on master/4.1/4.0, passes on 3.0#57252changed the FE defaultinverted_index_storage_formatfromV2toV3, but this test still created its table without pinning the property and assertedcheck_nested_index_file(..., 2, 3, "V2")with a hardcoded rowset count. Its sibling*_format_v2tests (test_cumulative_compaction_with_format_v2,test_mow_table_with_format_v2) were already migrated to a dynamic rowset count +"V3"; this one was missed.Fix: derive the post-compaction rowset count per tablet via
be_show_tablet_statusand assert"V3", mirroring the sibling tests.2.
test_curd_wlg— flakyThe
bypass_group(max_concurrency=0) check expectsselect count(1) from wlg_test_tableto be rejected withquery waiting queue is full. That identical query is run repeatedly earlier in the suite, so it can be served from the FE SQL result cache, which returns before a Coordinator is built and never enters the query queue — so the rejection never fires and the assertion sees no exception (but meet 'null').Fix: disable the SQL cache (
set enable_sql_cache=false) around this assertion so the query actually executes and hits the queue, then restore it.Further comments
Test-only changes. Cannot be verified locally (needs a deployed cluster with >= 2 BEs); please verify via CI.
🤖 Generated with Claude Code