Skip to content

branch-4.0: [fix](test) deflake test_curd_wlg and adapt test_single_replica_compaction_with_format_v2 to V3 default#64666

Merged
morningman merged 1 commit into
apache:branch-4.0from
morningman:fix/deflake-tc-198906-wlg-and-single-replica-compaction
Jun 22, 2026
Merged

branch-4.0: [fix](test) deflake test_curd_wlg and adapt test_single_replica_compaction_with_format_v2 to V3 default#64666
morningman merged 1 commit into
apache:branch-4.0from
morningman:fix/deflake-tc-198906-wlg-and-single-replica-compaction

Conversation

@morningman

Copy link
Copy Markdown
Contributor

Proposed changes

Fix two pre-existing branch-4.0 P0 regression-test failures (surfaced by an internal P0 build). Both are test-side issues, unrelated to product code.

1. test_single_replica_compaction_with_format_v2 — failed 100% on master/4.1/4.0, passes on 3.0

#57252 changed the FE default inverted_index_storage_format from V2 to V3, but this test still created its table without pinning the property and asserted check_nested_index_file(..., 2, 3, "V2") with a hardcoded rowset count. Its sibling *_format_v2 tests (test_cumulative_compaction_with_format_v2, test_mow_table_with_format_v2) were already migrated to a dynamic rowset count + "V3"; this one was missed.

Fix: derive the post-compaction rowset count per tablet via be_show_tablet_status and assert "V3", mirroring the sibling tests.

2. test_curd_wlg — flaky

The bypass_group (max_concurrency=0) check expects select count(1) from wlg_test_table to be rejected with query waiting queue is full. That identical query is run repeatedly earlier in the suite, so it can be served from the FE SQL result cache, which returns before a Coordinator is built and never enters the query queue — so the rejection never fires and the assertion sees no exception (but meet 'null').

Fix: disable the SQL cache (set enable_sql_cache=false) around this assertion so the query actually executes and hits the queue, then restore it.

Further comments

Test-only changes. Cannot be verified locally (needs a deployed cluster with >= 2 BEs); please verify via CI.

🤖 Generated with Claude Code

…_with_format_v2 to V3 default

Two pre-existing test failures surfaced by branch-4.0 P0 (TC build 198906),
both unrelated to the commit the pipeline ran on.

1) test_single_replica_compaction_with_format_v2 (failed 100% on master/4.1/4.0,
   passes on 3.0): apache#57252 changed the FE default inverted_index_storage_format
   from V2 to V3, but this test still hardcoded `check_nested_index_file(..., 2, 3,
   "V2")`. Its sibling format_v2 tests (cumulative / mow_table) were already
   migrated to a dynamic rowset count + "V3"; this one was missed. Derive the
   post-compaction rowset count per tablet via be_show_tablet_status and assert V3.

2) test_curd_wlg (flaky): the bypass_group (max_concurrency=0) assertion expects
   `select count(1) from wlg_test_table` to be rejected with "query waiting queue
   is full". That identical query is run repeatedly in the suite, so it can be
   served from the FE SQL result cache, which returns before building a Coordinator
   and never enters the query queue -> no rejection -> "but meet 'null'". Disable
   the SQL cache around this assertion so the query actually executes.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01CznUqKGNmRkCrYnks7SnWA
@hello-stephen

Copy link
Copy Markdown
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman

Copy link
Copy Markdown
Contributor Author

run buildall

@morningman morningman merged commit 28add52 into apache:branch-4.0 Jun 22, 2026
29 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants