[FLINK-34653] Support table merging with route#3129
Merged
Conversation
lvyanquan
reviewed
Mar 13, 2024
lvyanquan
left a comment
lvyanquan
left a comment
Contributor
There was a problem hiding this comment.
Thanks @PatrickRen for this contribution, left two comments.
| } | ||
| BinaryRecordDataGenerator recordDataGenerator = | ||
| new BinaryRecordDataGenerator( | ||
| routedTableSchema.getColumnDataTypes().toArray(new DataType[0])); |
Contributor
There was a problem hiding this comment.
Can we cache a tunple of routedTableSchema and its recordDataGenerator to avoid creating it for every event?
| } else { | ||
| RecordData.FieldGetter fieldGetter = | ||
| RecordData.createFieldGetter( | ||
| originalSchema.getColumn(columnName).get().getType(), columnIndex); |
Contributor
There was a problem hiding this comment.
Can we cache a tunple of originalSchema and its fieldGetterList? As RecordData.createFieldGetter will need to judge DataType and create new Object.
Contributor
|
@PatrickRen Thanks for your contribution, Could you rebase this PR to latest master? And I found the PR contains a WIP commit, Could you resolve it? |
leonardBang
approved these changes
Apr 16, 2024
leonardBang
left a comment
leonardBang
left a comment
Contributor
There was a problem hiding this comment.
Thanks @PatrickRen for the nice work, LGTM
wuzhenhua01
pushed a commit
to wuzhenhua01/flink-cdc-connectors
that referenced
this pull request
Aug 4, 2024
ChaomingZhangCN
pushed a commit
to ChaomingZhangCN/flink-cdc
that referenced
this pull request
Jan 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request supports complex table merging with route, including: