Skip to content

[FLINK-35441][tests] Add migration test cases#3365

Closed
yuxiqian wants to merge 1 commit into
apache:masterfrom
yuxiqian:FLINK-35441
Closed

[FLINK-35441][tests] Add migration test cases#3365
yuxiqian wants to merge 1 commit into
apache:masterfrom
yuxiqian:FLINK-35441

Conversation

@yuxiqian

@yuxiqian yuxiqian commented May 27, 2024

Copy link
Copy Markdown
Member

This closes FLINK-35441.

Adding backwards compatible test with 3.0.0 and 3.1.0 version by serializing objects on lower versions and deserializing them on snapshot version.

  • SchemaManager test runs on 3.1.0 only since commit bcad5d9 and [FLINK-34653] Support table merging with route #3129 changes SchemaRegistry serialization fields and breaks backwards compatibility.
  • SchemaRegistry test runs on 3.1.0 only, since it stores SchemaManager in its state.
  • ChangeTableInfo test runs on 3.1.0 only since Transform feature does not exist in 3.0.x.

Also noticed that there's no much classes using versioned serialization protocol, which couldn't guarantee backwards compatibility. Needs more discussion on how to refactor them.

@github-actions github-actions Bot added the build label May 27, 2024
@yuxiqian yuxiqian force-pushed the FLINK-35441 branch 5 times, most recently from 34f150d to e47077a Compare May 27, 2024 09:03
@yuxiqian

Copy link
Copy Markdown
Member Author

I'm not sure if it's OK to perform migration tests like so, could @leonardBang @PatrickRen please provide some advices on this? Thanks!

@yuxiqian yuxiqian changed the title [FLINK-35441][tests] Add migration test cases for SchemaManager and ChangeTableInfo [FLINK-35441][tests] Add migration test cases May 27, 2024
@yuxiqian yuxiqian force-pushed the FLINK-35441 branch 3 times, most recently from fee3309 to 25fcba1 Compare May 28, 2024 01:59
@leonardBang

Copy link
Copy Markdown
Contributor

Looks like we can close this PR as we've finish the tests in #3370 @yuxiqian

@yuxiqian yuxiqian closed this Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants