HADOOP-17205. Move personality file from Yetus to Hadoop repository by sunchao · Pull Request #2226 · apache/hadoop

sunchao · 2020-08-14T01:01:25Z

Currently for CI build and testing we maintain personality scripts in both Apache Yetus and Apache Hadoop. This poses problem when one needs to change both places, for example HADOOP-17125.

This proposes to move the personality file into the Hadoop repo itself, so that we can manage them in a single place. The downside for this is we may need to duplicate the scripts in every branch.

hadoop-yetus · 2020-08-14T01:15:58Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/1/console in case of problems.

hadoop-yetus · 2020-08-14T03:32:19Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 7s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1 💚	mvninstall	28m 50s	trunk passed
+1 💚	mvnsite	20m 16s	trunk passed
+1 💚	shadedclient	14m 2s	branch has no errors when building and testing our client artifacts.
		_ Patch Compile Tests _
+1 💚	mvninstall	19m 6s	the patch passed
+1 💚	mvnsite	17m 10s	the patch passed
+1 💚	shellcheck	0m 0s	There were no new shellcheck issues.
+1 💚	shelldocs	0m 18s	There were no new shelldocs issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	14m 10s	patch has no errors when building and testing our client artifacts.
		_ Other Tests _
+1 💚	unit	19m 27s	root in the patch passed.
+1 💚	asflicense	1m 4s	The patch does not generate ASF License warnings.
		137m 32s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/1/artifact/out/Dockerfile
GITHUB PR	#2226
Optional Tests	dupname asflicense shellcheck shelldocs mvnsite unit
uname	Linux 4184b6cdd2b6 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `86bbd38`
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/1/testReport/
Max. process+thread count	450 (vs. ulimit of 5500)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/1/console
versions	git=2.17.1 maven=3.6.0 shellcheck=0.4.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

sunchao · 2020-08-14T16:35:28Z

@aajisaka : this adds personality file to the trunk. Once agreed on this I'll also add to other branches.

aajisaka · 2020-08-17T01:46:38Z

In addition, I think we can revert apache/yetus#46 in Hadoop repository.

sunchao · 2020-08-17T05:38:51Z

Thanks @aajisaka . Addressed your comments and re-triggering CI.

hadoop-yetus · 2020-08-17T05:41:01Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/2/console in case of problems.

hadoop-yetus · 2020-08-17T07:58:16Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	1m 2s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1 💚	mvninstall	28m 47s	trunk passed
+1 💚	mvnsite	20m 19s	trunk passed
+1 💚	shadedclient	14m 19s	branch has no errors when building and testing our client artifacts.
		_ Patch Compile Tests _
+1 💚	mvninstall	19m 9s	the patch passed
+1 💚	mvnsite	17m 40s	the patch passed
+1 💚	shellcheck	0m 0s	There were no new shellcheck issues.
+1 💚	shelldocs	0m 18s	There were no new shelldocs issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	14m 0s	patch has no errors when building and testing our client artifacts.
		_ Other Tests _
+1 💚	unit	19m 46s	root in the patch passed.
+1 💚	asflicense	1m 2s	The patch does not generate ASF License warnings.
		138m 26s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/2/artifact/out/Dockerfile
GITHUB PR	#2226
Optional Tests	dupname asflicense shellcheck shelldocs mvnsite unit
uname	Linux c46257755145 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `5092ea6`
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/2/testReport/
Max. process+thread count	477 (vs. ulimit of 5500)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/2/console
versions	git=2.17.1 maven=3.6.0 shellcheck=0.4.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

hadoop-yetus · 2020-08-17T23:55:54Z

(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/3/console in case of problems.

hadoop-yetus · 2020-08-18T02:58:03Z

💔 -1 overall

Vote	Subsystem	Runtime	Comment
+0 🆗	reexec	31m 10s	Docker mode activated.
		_ Prechecks _
+1 💚	dupname	0m 0s	No case conflicting files found.
+1 💚	@author	0m 0s	The patch does not contain any @author tags.
-1 ❌	test4tests	0m 0s	The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
		_ trunk Compile Tests _
+1 💚	mvninstall	44m 13s	trunk passed
+1 💚	mvnsite	20m 13s	trunk passed
+1 💚	shadedclient	14m 8s	branch has no errors when building and testing our client artifacts.
		_ Patch Compile Tests _
+1 💚	mvninstall	18m 58s	the patch passed
+1 💚	mvnsite	17m 6s	the patch passed
+1 💚	shellcheck	0m 1s	There were no new shellcheck issues.
+1 💚	shelldocs	0m 18s	There were no new shelldocs issues.
+1 💚	whitespace	0m 0s	The patch has no whitespace issues.
+1 💚	shadedclient	14m 7s	patch has no errors when building and testing our client artifacts.
		_ Other Tests _
+1 💚	unit	20m 0s	root in the patch passed.
+1 💚	asflicense	1m 3s	The patch does not generate ASF License warnings.
		183m 6s

Subsystem	Report/Notes
Docker	ClientAPI=1.40 ServerAPI=1.40 base: https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/3/artifact/out/Dockerfile
GITHUB PR	#2226
Optional Tests	dupname asflicense shellcheck shelldocs mvnsite unit
uname	Linux 7cca94bd6377 4.15.0-112-generic #113-Ubuntu SMP Thu Jul 9 23:41:39 UTC 2020 x86_64 x86_64 x86_64 GNU/Linux
Build tool	maven
Personality	dev-support/bin/hadoop.sh
git revision	trunk / `b367942`
Test Results	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/3/testReport/
Max. process+thread count	414 (vs. ulimit of 5500)
modules	C: . U: .
Console output	https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-2226/3/console
versions	git=2.17.1 maven=3.6.0 shellcheck=0.4.6
Powered by	Apache Yetus 0.13.0-SNAPSHOT https://yetus.apache.org

This message was automatically generated.

aajisaka

+1, thank you @sunchao

…2226) Signed-off-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit fefacf2)

HADOOP-17205. Move personality file from Yetus to Hadoop repository

ced086a

sunchao requested a review from aajisaka August 14, 2020 16:34

aajisaka reviewed Aug 17, 2020

View reviewed changes

Comment thread dev-support/bin/hadoop.sh Outdated

sunchao added 2 commits August 16, 2020 22:30

Revert HDDS and SUBMARINE

c22dae3

Revert YETUS-816

b47448c

aajisaka reviewed Aug 17, 2020

View reviewed changes

Comment thread Jenkinsfile

Add back --project=hadoop

bce959c

aajisaka self-requested a review August 18, 2020 03:04

aajisaka approved these changes Aug 18, 2020

View reviewed changes

aajisaka merged commit fefacf2 into apache:trunk Aug 18, 2020

aajisaka pushed a commit that referenced this pull request Aug 18, 2020

HADOOP-17205. Move personality file from Yetus to Hadoop repository (#…

197219a

…2226) Signed-off-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit fefacf2)

aajisaka pushed a commit that referenced this pull request Aug 18, 2020

HADOOP-17205. Move personality file from Yetus to Hadoop repository (#…

5858c74

…2226) Signed-off-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit fefacf2)

aajisaka pushed a commit that referenced this pull request Aug 18, 2020

HADOOP-17205. Move personality file from Yetus to Hadoop repository (#…

bd3817b

…2226) Signed-off-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit fefacf2)

aajisaka pushed a commit that referenced this pull request Aug 18, 2020

HADOOP-17205. Move personality file from Yetus to Hadoop repository (#…

c7ab319

…2226) Signed-off-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit fefacf2)

aajisaka pushed a commit that referenced this pull request Aug 18, 2020

HADOOP-17205. Move personality file from Yetus to Hadoop repository (#…

412f30d

…2226) Signed-off-by: Akira Ajisaka <aajisaka@apache.org> (cherry picked from commit fefacf2)

sunchao mentioned this pull request Aug 18, 2020

HADOOP-17125. Using snappy-java in SnappyCodec #2201

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

HADOOP-17205. Move personality file from Yetus to Hadoop repository#2226

HADOOP-17205. Move personality file from Yetus to Hadoop repository#2226
aajisaka merged 4 commits into
apache:trunkfrom
sunchao:HADOOP-17205

sunchao commented Aug 14, 2020

Uh oh!

hadoop-yetus commented Aug 14, 2020

Uh oh!

hadoop-yetus commented Aug 14, 2020

Uh oh!

sunchao commented Aug 14, 2020

Uh oh!

Uh oh!

aajisaka commented Aug 17, 2020

Uh oh!

sunchao commented Aug 17, 2020

Uh oh!

hadoop-yetus commented Aug 17, 2020

Uh oh!

hadoop-yetus commented Aug 17, 2020

Uh oh!

Uh oh!

hadoop-yetus commented Aug 17, 2020

Uh oh!

hadoop-yetus commented Aug 18, 2020

Uh oh!

aajisaka left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

sunchao commented Aug 14, 2020

Uh oh!

hadoop-yetus commented Aug 14, 2020

Uh oh!

hadoop-yetus commented Aug 14, 2020

Uh oh!

sunchao commented Aug 14, 2020

Uh oh!

Uh oh!

aajisaka commented Aug 17, 2020

Uh oh!

sunchao commented Aug 17, 2020

Uh oh!

hadoop-yetus commented Aug 17, 2020

Uh oh!

hadoop-yetus commented Aug 17, 2020

Uh oh!

Uh oh!

hadoop-yetus commented Aug 17, 2020

Uh oh!

hadoop-yetus commented Aug 18, 2020

Uh oh!

aajisaka left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants