YETUS-816. Improve hadoop personality to support ozone/hdds projects#46
Merged
Conversation
|
(!) A patch to the testing environment has been detected. |
|
💔 -1 overall
This message was automatically generated. |
aw-was-here
requested changes
Mar 7, 2019
| personality_enqueue_module ${module} ${extra} | ||
| OZONE_CHANGED=false | ||
| CORE_HADOOP_CHANGED=false | ||
| for module in $CHANGED_MODULES |
Contributor
There was a problem hiding this comment.
CHANGED_MODULES is an array, not a string. You want "${CHANGED_MODULES[@]}" here. (Also, looks like a bug in shellcheck: it should have flagged that.)
Member
Author
There was a problem hiding this comment.
Thanks a lot, fixed.
(BTW, It was not flagged, I don't know why:
precommit/src/main/shell/personality/hadoop.sh:426:46: note: Double quote to prevent globbing and word splitting. [SC2086]
precommit/src/main/shell/personality/hadoop.sh:427:47: note: Double quote to prevent globbing and word splitting. [SC2086]
I tested with a simple shell script and similar structure was flagged there. I think the type of the CHANGED_MODULES is unknown here...)
aw-was-here
requested changes
Mar 7, 2019
| if [ "$CORE_HADOOP_CHANGED" = false ] && [ "$OZONE_CHANGED" = true ]; then | ||
| if [ "$testtype" != "mvnsite" ] && [ "$testtype" != "shadedclient" ]; then | ||
| personality_enqueue_module hadoop-hdds ${extra} | ||
| personality_enqueue_module hadoop-ozone ${extra} |
|
|
||
| if [ "$CORE_HADOOP_CHANGED" = false ] && [ "$OZONE_CHANGED" = true ]; then | ||
| if [ "$testtype" != "mvnsite" ] && [ "$testtype" != "shadedclient" ]; then | ||
| personality_enqueue_module hadoop-hdds ${extra} |
Contributor
There was a problem hiding this comment.
shellcheck disable the message here. extra should have been an array but it wasn't when we first wrote yetus.
elek
changed the title
|
(!) A patch to the testing environment has been detected. |
|
🎊 +1 overall
This message was automatically generated. |
aw-was-here
approved these changes
Mar 7, 2019
Member
Author
|
Thank you @aw-was-here the review and merge. I created a PR for hadoop to use the latest yetus which includes this change. apache/hadoop#599 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ozone/Hdds projects are not handled very well in the hadoop personality as in case of an ozone change all the hdds/ozone projects should be built and tested