Migrate non TestBase related and Data classes in Flink#10130
Merged
Conversation
nastra
reviewed
Apr 12, 2024
| required(117, "time", Types.TimeType.get())); | ||
|
|
||
| @Rule public TemporaryFolder temp = new TemporaryFolder(); | ||
| @TempDir public Path temp; |
nastra
reviewed
Apr 12, 2024
| .build()) { | ||
| CloseableIterator it = reader.iterator(); | ||
| Assert.assertTrue("Should have at least one row", it.hasNext()); | ||
| assertThat(it.hasNext()).isTrue(); |
Contributor
There was a problem hiding this comment.
Suggested change
| assertThat(it.hasNext()).isTrue(); | |
| assertThat(it).hasNext(); |
nastra
reviewed
Apr 12, 2024
| Assert.assertFalse("Should not have more than one row", it.hasNext()); | ||
| assertThat(actualRecord.get(0, ArrayList.class)).first().isEqualTo(expectedBinary); | ||
| assertThat(actualRecord.get(1, ByteBuffer.class)).isEqualTo(expectedBinary); | ||
| assertThat(it.hasNext()).isFalse(); |
nastra
reviewed
Apr 12, 2024
| fileSchema -> GenericParquetReaders.buildReader(schema, fileSchema)) | ||
| .build() | ||
| .iterator()) | ||
| .as("Decrypted without keys") |
Contributor
There was a problem hiding this comment.
.as() isn't needed. It should rather have a .hasMessage check
nastra
reviewed
Apr 12, 2024
| Assert.assertFalse("Should not have more than one row", it.hasNext()); | ||
| assertThat(actualRecord.get(0, ArrayList.class)).first().isEqualTo(expectedBinary); | ||
| assertThat(actualRecord.get(1, ByteBuffer.class)).isEqualTo(expectedBinary); | ||
| assertThat(it.hasNext()).isFalse(); |
nastra
reviewed
Apr 12, 2024
| Iterator<RowData> rows = reader.iterator(); | ||
| for (int i = 0; i < numRecord; i++) { | ||
| Assert.assertTrue("Should have expected number of records", rows.hasNext()); | ||
| assertThat(rows.hasNext()).isTrue(); |
Contributor
There was a problem hiding this comment.
same as previously mentioned. please also update all other places
tomtongue
changed the title
Contributor
Author
|
@nastra thanks for the review. Reflected your feedback and migrate other classes. Could you review? |
nastra
reviewed
Apr 15, 2024
| import org.junit.jupiter.api.Test; | ||
| import org.junit.jupiter.api.io.TempDir; | ||
|
|
||
| public class TestRowProjection { |
Contributor
There was a problem hiding this comment.
In the Flink codebase we need to make sure that the same code changes are being applied across all 3 versions. So if you're touching this file here, you would also need to make sure to apply the same changes for the other Flink versions.
This can be either done within the same PR or in an immediate follow-up that backports the same changes to earlier versions
nastra
approved these changes
Apr 15, 2024
Contributor
|
changes LGTM, can you please backport these changes to earlier Flink versions? |
Contributor
Author
|
Sure. Will submit a PR for backporting. Thank you. |
12 tasks
sasankpagolu
pushed a commit
to sasankpagolu/iceberg
that referenced
this pull request
Oct 27, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the following classes in
iceberg-flinkandiceberg-datato JUnit 5 for #9087Current Progress
iceberg-flink(v1.18)AvroGenericRecordConverterBaseTestAvroGenericRecordToRowDataMapperTestRowDataToAvroGenericRecordConverterTestDataFileSerializationTestFlinkCatalogFactoryTestFlinkFiltersTestFlinkSchemaUtilTestManifestFileSerializationTestRowDataWrapper(<RecordWrapperTest)TestTableSerializationutil/TestFlinkPackagedata/TestFlinkAvroReaderWriter(<DataTest) (including v1.16 and v1.17)TestFlinkOrcReaderWriter(<DataTest) (including v1.16 and v1.17)TestFlinkParquetReader(<DataTest) (including v1.16 and v1.17)TestFlinkParquetWriter(<DataTest) (including v1.16 and v1.17)TestRowProjectionTestStructRowDataDataTestrelated classes iniceberg-data:avro/TestGenericDataorc/TestGenericDataparquet/TestGenericDataTestParquetEncryptionWithWriteSupport