Backport Flink 1.18 JUnit5 migration to Flink 1.17#10163
Merged
Conversation
tomtongue
force-pushed
the
mig-junit5-flink-backport#10130
branch
from
9f1779f to
03da4ca
Compare
tomtongue
changed the title
tomtongue
changed the title
Contributor
Author
|
@nastra Could you review this PR? If I should migrate more files to this PR, please let me know. |
nastra
approved these changes
Apr 17, 2024
Contributor
nastra
left a comment
nastra
left a comment
There was a problem hiding this comment.
LGTM, thanks @tomtongue.
Just FYI that Flink 1.19 has been just merged and Flink 1.16 has been removed. Going forward, let's focus on migrating the remaining tests in Flink 1.19 and then also backport those to Flink 1.18/1.17 (the backport PRs should have identical changes to the changes required for Flink 1.19)
Contributor
Author
|
Sure, thanks for kindly letting me know that. Will submit a PR for Flink 1.9 including backport to other versions. |
sasankpagolu
pushed a commit
to sasankpagolu/iceberg
that referenced
this pull request
Oct 27, 2024
zachdisc
pushed a commit
to zachdisc/iceberg
that referenced
this pull request
Dec 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport the v1.18 changes in #10130 to v1.17
and v1.16(v1.16 was already removed, so skipped the migration for this version)AvroGenericRecordConverterBaseTestAvroGenericRecordToRowDataMapperTestRowDataToAvroGenericRecordConverterTestDataFileSerializationTestFlinkCatalogFactoryTestFlinkFiltersTestFlinkSchemaUtilTestManifestFileSerializationTestRowDataWrapperTestTableSerializationutil/TestFlinkPackage