[MINOR] Code Cleanup (Clients Module)#16049
Merged
chia7712 merged 6 commits intoapache:trunkfrom Jun 4, 2024
Merged
Conversation
Closed
Member
|
@sjhajharia Could you please rebase code to include #16044? It fixes a lot of failed tests :) |
Collaborator
Author
|
Thanks for pointing out @chia7712 |
Member
I guess other PRs will encounter same failed tests, so please rebase code for others too, thanks! |
chia7712
reviewed
May 29, 2024
Member
chia7712
left a comment
chia7712
left a comment
There was a problem hiding this comment.
@sjhajharia thanks for updated PR
TaiJuWu
pushed a commit
to TaiJuWu/kafka
that referenced
this pull request
Jun 8, 2024
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
gongxuanzhang
pushed a commit
to gongxuanzhang/kafka
that referenced
this pull request
Jun 12, 2024
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Code Cleanup in Clients Module
Changes
Some common changes include
Thanks!