Skip to content

[MINOR] Code Cleanup#16021

Closed
sjhajharia wants to merge 3 commits intoapache:trunkfrom
sjhajharia:code-cleanup
Closed

[MINOR] Code Cleanup#16021
sjhajharia wants to merge 3 commits intoapache:trunkfrom
sjhajharia:code-cleanup

Conversation

@sjhajharia
Copy link
Copy Markdown
Collaborator

@sjhajharia sjhajharia commented May 21, 2024

What

Code Cleanup

Changes

Some common changes include

  • Replace the Arrays.asList() with Collections.singletonList() wherever possible
  • Cleaning up some if-else blocks
  • Replacing some instances of String.builder() with String operations

@sjhajharia sjhajharia marked this pull request as ready for review May 21, 2024 16:51
@chia7712
Copy link
Copy Markdown
Member

@sjhajharia Thanks for this great contribution. However, we normally do such refactor one module by one module. For example: #15967, #15955, and #15877

The huge PR is un-reviewable and so it will be easy to make broken changes. Hence, could you please separate it into small PRs?

@sjhajharia
Copy link
Copy Markdown
Collaborator Author

Hey @chia7712
Thanks for the comment. I was also in a split brain regarding the same. I will close this one and create child PRs with one/two modules targetted at a time for an easier review.
Thanks!

@sjhajharia sjhajharia closed this May 23, 2024
@sjhajharia
Copy link
Copy Markdown
Collaborator Author

Hey @chia7712
I have created 5 sub-PRs to address the cleanup module-by-module.

Hope that folks can chime in and provide their feedbacks.
Good Day!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants