Skip to content

[MINOR] Code Cleanup - Connect Module#16066

Merged
chia7712 merged 2 commits intoapache:trunkfrom
sjhajharia:connect-code-cleanup
May 30, 2024
Merged

[MINOR] Code Cleanup - Connect Module#16066
chia7712 merged 2 commits intoapache:trunkfrom
sjhajharia:connect-code-cleanup

Conversation

@sjhajharia
Copy link
Copy Markdown
Collaborator

What

Code Cleanup in Connect Module

Changes

Some common changes include

  • Replace the Arrays.asList() with Collections.singletonList() wherever possible
  • Cleaning up some if-else blocks
  • Replacing some instances of String.builder() with String operations

Thanks!

Copy link
Copy Markdown
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chia7712 chia7712 merged commit e974914 into apache:trunk May 30, 2024
chiacyu pushed a commit to chiacyu/kafka that referenced this pull request Jun 1, 2024
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
wernerdv pushed a commit to wernerdv/kafka that referenced this pull request Jun 3, 2024
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
TaiJuWu pushed a commit to TaiJuWu/kafka that referenced this pull request Jun 8, 2024
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
gongxuanzhang pushed a commit to gongxuanzhang/kafka that referenced this pull request Jun 12, 2024
Reviewers: Chia-Ping Tsai <chia7712@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants