KAFKA-10787: Apply spotless to raft module#16278
Merged
chia7712 merged 6 commits intoapache:trunkfrom Jun 15, 2024
Merged
Conversation
Member
|
@gongxuanzhang could you please the conflicts? BTW, it would be easy to apply the spotless to small/inactive modules first. For example: |
Contributor
Author
Right,next PR will apply all of these modules. |
Member
|
@gongxuanzhang please rebase code to fix spotless check :) |
This was referenced Jun 12, 2024
Member
|
@gongxuanzhang you need to fix it again :) |
Contributor
Author
Ok,I'll fix it periodically before merging |
This was referenced Jun 16, 2024
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is sub PR from #16097.
It is part of a series of changes to progressively apply [spotless plugin(import-order)] across all modules. In this step, the plugin is activated in the
raftmodule.Module and history
How to test:
We can run
./gradlew spotlessCheckcheck for code that does not meet requirements.If we get report that error , we can run
./gradlew spotlessApplyto review my code.In this PR, all change(exclude
build.gradle)byspotlessApply`