Skip to content

KAFKA-10787: Apply spotless to stream:test-utils and :streams:upgrade-system-tests-xxxx #16357

Merged
chia7712 merged 2 commits intoapache:trunkfrom
gongxuanzhang:spotless-stream-100
Jun 17, 2024
Merged

KAFKA-10787: Apply spotless to stream:test-utils and :streams:upgrade-system-tests-xxxx #16357
chia7712 merged 2 commits intoapache:trunkfrom
gongxuanzhang:spotless-stream-100

Conversation

@gongxuanzhang
Copy link
Copy Markdown
Contributor

@gongxuanzhang gongxuanzhang commented Jun 16, 2024

This PR is sub PR from #16097.
It is part of a series of changes to progressively apply [spotless plugin(import-order)] across all modules. In this step, the plugin is activated in the

  • stream:test-utils
  • streams:upgrade-system-tests-0100

Module and history

Please see the table below for the historical changes related to applying the Spotless plugin

module apply related PR
:clients future
:connect:api #16299
:connect:basic-auth-extension #16299
:connect:file #16299
:connect:json #16299
:connect:mirror #16299
:connect:mirror-client #16299
:connect:runtime future
:connect:test-plugins #16299
:connect:transforms #16299
:core future
:examples #16296
:generator #16296
:group-coordinator:group-coordinator-api #16298
:group-coordinator #16298
:jmh-benchmarks #16296
:log4j-appender #16296
:metadata #16297
:server #16297
:shell #16296
:storage #16297
:storage:storage-api #16297
:streams future
:streams:examples future
:streams:streams-scala future
:streams:test-utils #16357
:streams:upgrade-system-tests-0100 #16357
:streams:upgrade-system-tests-0101 #16357
:streams:upgrade-system-tests-0102 #16357
:streams:upgrade-system-tests-0110 #16357
:streams:upgrade-system-tests-10 #16357
:streams:upgrade-system-tests-11 #16357
:streams:upgrade-system-tests-20 #16357
:streams:upgrade-system-tests-21 #16357
:streams:upgrade-system-tests-22 #16357
:streams:upgrade-system-tests-23 #16357
:streams:upgrade-system-tests-24 #16357
:streams:upgrade-system-tests-25 #16357
:streams:upgrade-system-tests-26 #16357
:streams:upgrade-system-tests-27 #16357
:streams:upgrade-system-tests-28 #16357
:streams:upgrade-system-tests-30 #16357
:streams:upgrade-system-tests-31 #16357
:streams:upgrade-system-tests-32 #16357
:streams:upgrade-system-tests-33 #16357
:streams:upgrade-system-tests-34 #16357
:streams:upgrade-system-tests-35 #16357
:streams:upgrade-system-tests-36 #16357
:streams:upgrade-system-tests-37 #16357
:trogdor #16296
:raft #16278
:server-common #16172
:transaction-coordinator #16172
:tools #16262
:tools:tools-api #16262

How to test:

We can run ./gradlew spotlessCheck check for code that does not meet requirements.
If we get report that error , we can run ./gradlew spotlessApply to review my code.
In this PR, all change(exclude build.gradle) byspotlessApply`

import static org.mockito.Mockito.withSettings;

@RunWith(MockitoJUnitRunner.StrictStubs.class)
@ExtendWith(MockitoExtension.class)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those changes are unrelated to this PR, right?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

o my bad sorry

@gongxuanzhang gongxuanzhang changed the title KAFKA-10787: Apply spotless to stream:test-utils and :streams:upgrade-system-tests-0100 KAFKA-10787: Apply spotless to stream:test-utils and :streams:upgrade-system-tests-xxxx Jun 17, 2024
Copy link
Copy Markdown
Member

@chia7712 chia7712 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants