update specs and implementation plan#329
Conversation
- mentoring-mode: proposed → experimental; pr-management-mentor now shipped, update Where-it-lives and Known-gaps accordingly - pairing-mode: proposed → experimental; pairing-self-review now shipped, update Where-it-lives and Known-gaps accordingly - overview: update mode table (Mentoring, Pairing: 0 skills → 1 skill, proposed → experimental); add security-reporting to cross-cutting table - triage-mode: add contributor-nomination (contributor-readiness brief), issue-reassess-stats (campaign dashboard), tools/pr-management-stats reference implementation, and tools/mail-source to Where-it-lives - agent-isolation-sandbox: add setup-isolated-setup-doctor to skills list - meta-and-quality-tooling: add tools/spec-status-index and tools/spec-validator to Where-it-lives - adapters: rename title/source/Acceptance to include mail-source; document tools/mail-source abstract backend contract + IMAP + mbox - security-reporting.md: new spec for security-tracker-stats-dashboard skill and tools/security-tracker-stats-dashboard tool - README + overview indexes updated to reference security-reporting.md Generated-by: Claude (Opus 4.7)
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
LGTM — solid catch-up sync that brings the spec layer back in line with merged
work: mentoring-mode and pairing-mode correctly flip proposed →
experimental, the overview mode-table updates match docs/modes.md,
adapters.md and triage-mode.md accurately incorporate
tools/mail-source/, and the new security-reporting.md spec is
well-formed with sensible acceptance criteria. The rebase against current
main is clean; validator exits 0.
Smaller observations (worth a follow-up sync-specs pass)
IMPLEMENTATION_PLAN.md— Work item 2 (agent-isolation Python
packaging + test harness) is already done inmainvia #339:
tools/agent-isolation/pyproject.toml+tests/are both present
(test_claude_iso.py, test_sandbox_add_project_root.py,
test_sandbox_bypass_warn.py). Safe to drop this item from the next
plan refresh; the loop would catch it as a no-op but it wastes an
iteration to surface.IMPLEMENTATION_PLAN.mdDone — "24 skill eval suites committed"
is now 29 after this session merged #330–#335 (six setup-family
suites).IMPLEMENTATION_PLAN.mdIn-flight table — the sixeval-setup-*
branches just merged this session and can come off the list; PR #227
(contribitor-readiness) is shown as draft but is actually CLOSED
(content already merged via another path).
None of these block the merge — they're follow-up bookkeeping for the
next sync-specs iteration.
This review was drafted by an AI-assisted tool and confirmed by an Apache Steward
maintainer. The maintainer approving this PR has read the findings and signed off.
If something feels off, please reply on the PR and a maintainer will follow up.More on how Apache Steward handles maintainer review:
CONTRIBUTING.md.
2 participants
Summary
update specs and implementation plan based on what's been done so far.
Type of change
.claude/skills/<name>/) — eval fixtures updated belowtools/<system>/*.md)tools/*/withpyproject.toml)docs/,README.md,CONTRIBUTING.md)projects/_template/)prek, workflows, validators)Test plan
prek run --all-filespassesuv run pytest/ruff check/mypypasses(
PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/)(a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)