Skip to content

feat(evals): add eval suite for setup-isolated-setup-update skill#330

Merged
potiuk merged 1 commit into
apache:mainfrom
justinmclean:eval-setup-isolated-setup-update
May 27, 2026
Merged

feat(evals): add eval suite for setup-isolated-setup-update skill#330
potiuk merged 1 commit into
apache:mainfrom
justinmclean:eval-setup-isolated-setup-update

Conversation

@justinmclean

@justinmclean justinmclean commented May 27, 2026

Copy link
Copy Markdown
Member

Summary

13 cases across 3 suites (step-snapshot-drift, step-tool-freshness, step-after-report):

  • step-snapshot-drift: clean, ref mismatch, method/URL mismatch, svn-zip SHA-512 mismatch — all four lock-file drift severities
  • step-tool-freshness: all current, one past cooldown, multiple past cooldown, within cooldown, injection resistance (hidden HTML comment must not suppress a genuine upgrade candidate)
  • step-after-report: all-in-sync, framework behind + snapshot sync, script + settings drift, verify regression (stops alone)

Generated-by: Claude (Opus 4.7)

Type of change

  • Skill change (.claude/skills/<name>/) — eval fixtures updated below
  • Tool / bridge contract (tools/<system>/*.md)
  • Python package (tools/*/ with pyproject.toml)
  • Groovy reference impl
  • Cross-cutting (RFC, AGENTS.md, sandbox, privacy-LLM)
  • Documentation (docs/, README.md, CONTRIBUTING.md)
  • Project template (projects/_template/)
  • CI / dev loop (prek, workflows, validators)
  • Other: more tests

Test plan

  • prek run --all-files passes
  • For Python packages touched: uv run pytest / ruff check / mypy passes
  • For Groovy bridges touched: command-line invocation tested end-to-end
  • For skill changes: eval suite passes for the affected skill
    (PYTHONPATH=tools/skill-evals/src python3 -m skill_evals.runner tools/skill-evals/evals/<skill>/)
  • For skill behaviour changes: a new or updated eval fixture is included in this PR
    (a regression test for the bug fixed / the behaviour added — see CONTRIBUTING.md)
  • Other:

@justinmclean justinmclean self-assigned this May 27, 2026
@potiuk potiuk force-pushed the eval-setup-isolated-setup-update branch from b2abc21 to fd335ca Compare May 27, 2026 19:44
13 cases across 3 suites (step-snapshot-drift, step-tool-freshness,
step-after-report):
- step-snapshot-drift: clean, ref mismatch, method/URL mismatch,
  svn-zip SHA-512 mismatch — all four lock-file drift severities
- step-tool-freshness: all current, one past cooldown, multiple
  past cooldown, within cooldown, injection resistance (hidden
  HTML comment must not suppress a genuine upgrade candidate)
- step-after-report: all-in-sync, framework behind + snapshot
  sync, script + settings drift, verify regression (stops alone)

Generated-by: Claude (Opus 4.7)
@potiuk potiuk force-pushed the eval-setup-isolated-setup-update branch from fd335ca to 430987d Compare May 27, 2026 22:40

@potiuk potiuk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — 13 cases across the three highest-signal steps in
setup-isolated-setup-update (snapshot-drift, tool-freshness, after-report).
All three step-configs resolve to real SKILL.md headings. The injection
case at step-tool-freshness correctly preserves real-state output. Runner
walks all 13 cases without parse errors.


This review was drafted by an AI-assisted tool and confirmed by an Apache Steward
maintainer. The maintainer approving this PR has read the findings and signed off.
If something feels off, please reply on the PR and a maintainer will follow up.

More on how Apache Steward handles maintainer review:
CONTRIBUTING.md.

@potiuk potiuk merged commit d90cbb2 into apache:main May 27, 2026
15 checks passed
@potiuk potiuk mentioned this pull request May 27, 2026
15 tasks
@justinmclean justinmclean deleted the eval-setup-isolated-setup-update branch May 28, 2026 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants