Histostat metrics support#3
Conversation
|
re formatting with black, I note that the github workflow has a completely different linting setup to that done with |
guyboltonking
left a comment
guyboltonking
left a comment
There was a problem hiding this comment.
+1 with a couple of nits. I have a PR that I can submit if you give me access that handles the issues I highlighted earlier with flake8/black/formatting enforcement in general.
| raise ValueError("graphite.url") | ||
| graphite_config = GraphiteConfig(url=config["graphite"]["url"]) | ||
| if config.get("grafana") is None: | ||
| config["gafana"] = {} |
There was a problem hiding this comment.
This misspelling (gafana) was already there, but a) perhaps we could fix it b) the fact that it doesn't seem to break anything suggests it either isn't needed, or it's always been broken and was never used?
There was a problem hiding this comment.
Fixed in the last commit. It is broken, but I think we haven't hit it because all of the configs I've seen / used explicitly define a grafana section.
…tart of time The csv samples are dated early 2021, and the default data selection since_time is set to one year prior to runtime. All of the csv samples had 'expired'. We want to keep the default since_time behavior and not have to regularly update the dates in the csv samples.
* remove f strings which don't have placeholders * fix typo in grafana config * supress warnings about E203 which is created by black formatting
smccarthy788
force-pushed
the
histostat-support
branch
from
312eab5 to
96a8973
Compare
2 participants
Adds 'histostat' CSV files as a metrics source. An example
histostat.csvis included from a NoSqlBench test.The intended use case is in automation: a Fallout test produces a histostat artifact, processed by Hunter which outputs the change points in json format, which Fallout can then ingest to apply pass/fail logic per test run.
This use case required two separate changes: