Harmonise build#4
Merged
Merged
Conversation
guyboltonking
force-pushed
the
gbk-harmonise-build
branch
from
ea0c224 to
4bb4bd3
Compare
smccarthy788
approved these changes
Apr 20, 2022
|
|
||
| ``` | ||
| poetry run pytest tests | ||
| ./poetry run pytest tests |
Contributor
There was a problem hiding this comment.
Suggested change
| ./poetry run pytest tests | |
| ./poetryw run pytest tests |
I think?
guyboltonking
force-pushed
the
gbk-harmonise-build
branch
from
4bb4bd3 to
d5922b7
Compare
Also fix minor flake8 errors in util.py and config.py
guyboltonking
force-pushed
the
gbk-harmonise-build
branch
from
d5922b7 to
8b044a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently builds on top of #3; this implements the suggestions to harmonise the CI in GH actions by using tox to drive everything.
It adds wrapper scripts for tox and poetry, which create a venv, install the respective tool, and run it. This removes any requirement on the caller to mess around with setting up venvs, while not preventing their usage should developers wish to do so.
It also enforces import ordering and removal of redundant imports using
autoflakeandisort.