Skip to content

[ISSUE-328] gets last message when LatestMessageID and inclusive - #329

Merged
wolfstudy merged 4 commits into
apache:masterfrom
quintans:last-message-inclusive
Aug 24, 2020
Merged

[ISSUE-328] gets last message when LatestMessageID and inclusive#329
wolfstudy merged 4 commits into
apache:masterfrom
quintans:last-message-inclusive

Conversation

@quintans

@quintans quintans commented Jul 22, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Signed-off-by: Paulo Pereira paulo.quintans@gmail.com

Fixes #328

Motivation

I have a service that when it restarts, it needs to know what was the last message successfully sent to pulsar.
A reader seems the logical place, since we can specify StartMessageID as LatestMessageID() and StartMessageIDInclusive

Modifications

When the reader is created, verify if it startMessageIDInclusive true and startMessageID == lastestMessageID() and then get the last message id and seek to that message id.

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • integration tests to verify that a reader has the last message, when specifying StartMessageIDInclusive and LastestMessageID

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): no
  • The public API: no
  • The schema: no
  • The default values of configurations: no
  • The wire protocol: no

Documentation

  • Does this pull request introduce a new feature? no

@quintans quintans changed the title [ISSUE-328][reader] gets last message when LatestMessageID and inclusive [ISSUE-328] gets last message when LatestMessageID and inclusive Jul 22, 2020
@quintans quintans mentioned this pull request Jul 23, 2020
Closed
Paulo Pereira added 4 commits July 23, 2020 17:23
Paulo Pereira
ISSUE-328 reader gets last message when LatestMessageID and inclusive
bb2910f 
Signed-off-by: Paulo Pereira <paulo.pereira@karhoo.com>
Paulo Pereira
[ISSUE-328] get last message when asking for LatestMessageID and incl…
0347336 
…usive

Signed-off-by: Paulo Pereira <paulo.pereira@karhoo.com>
Paulo Pereira
[ISSUE-328] test if there is no message
50ac51c 
Signed-off-by: Paulo Pereira <paulo.pereira@karhoo.com>
Paulo Pereira
[ISSUE-328] rebase and tidy
5ee5bb2 
Signed-off-by: Paulo Pereira <paulo.pereira@karhoo.com>
@quintans
quintans force-pushed the last-message-inclusive branch from d64fffc to 5ee5bb2 Compare July 23, 2020 16:27
@wolfstudy wolfstudy added this to the 0.2.0 milestone Aug 24, 2020
wolfstudy
wolfstudy approved these changes Aug 24, 2020
View reviewed changes

@wolfstudy wolfstudy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1

@wolfstudy
wolfstudy merged commit a7e7239 into apache:master Aug 24, 2020
@wolfstudy wolfstudy mentioned this pull request Aug 24, 2020
Closed
rueian added a commit to rueian/pulsar-client-go that referenced this pull request Feb 15, 2021
@rueian
Fix reader with start latest message id inclusive (apache#329)
85b0163 
Fixes apache#356
Fixes apache#419

Motivtions

The changes made by the original PR apache#329 are no longer works.
This PR is trying to fix the bugs and make the test case be more robust.

Moditications

* fix the wrong `pc.startMessageID == lastestMessageID` with `pc.startMessageID.equal(lastestMessageID.(messageID))`
* fix the hanging `pc.requestSeek(msgID.messageID)` with `pc.requestSeekWithoutClear(msgID.messageID)` before the dispatch loop
* make `HasNext()` return true in case of `StartMessageIdInclusive` and `LastestMessageID`
* make `TestReaderLatestInclusiveHasNext` test case be more robust
@rueian rueian mentioned this pull request Feb 15, 2021
Merged
1 task
rueian added a commit to rueian/pulsar-client-go that referenced this pull request Feb 16, 2021
@rueian
Fix reader with start latest message id inclusive (apache#329)
efb1529 
Fixes apache#356
Fixes apache#419

Motivtions

The changes made by the original PR apache#329 are no longer works.
This PR is trying to fix the bugs and make the test case be more robust.

Moditications

* fix the wrong `pc.startMessageID == lastestMessageID` with `pc.startMessageID.equal(lastestMessageID.(messageID))`
* fix the hanging `pc.requestSeek(msgID.messageID)` with `pc.requestSeekWithoutClear(msgID.messageID)` before the dispatch loop
* make `TestReaderLatestInclusiveHasNext` test case be more robust
rueian added a commit to rueian/pulsar-client-go that referenced this pull request Feb 16, 2021
@rueian
Fix reader with start latest message id inclusive (apache#329)
6f661bc 
Fixes apache#356
Fixes apache#419

Motivtions

The changes made by the original PR apache#329 are no longer works.
This PR is trying to fix the bugs and make the test case be more robust.

Moditications

* fix the wrong `pc.startMessageID == lastestMessageID` with `pc.startMessageID.equal(lastestMessageID.(messageID))`
* fix the hanging `pc.requestSeek(msgID.messageID)` with `pc.requestSeekWithoutClear(msgID.messageID)` before the dispatch loop
* make the `HasNext()` return true in case of `StartMessageIdInclusive` and `LastestMessageID`
* make the `TestReaderLatestInclusiveHasNext` test case be more robust
rueian added a commit to rueian/pulsar-client-go that referenced this pull request Feb 16, 2021
@rueian
Fix reader with start latest message id inclusive (apache#329)
77e7fff 
Fixes apache#356
Fixes apache#419

Motivtions

The changes made by the original PR apache#329 are no longer works.
This PR is trying to fix the bugs and make the test case be more robust.

Moditications

* fix the wrong `pc.startMessageID == lastestMessageID` with `pc.startMessageID.equal(lastestMessageID.(messageID))`
* fix the hanging `pc.requestSeek(msgID.messageID)` with `pc.requestSeekWithoutClear(msgID.messageID)` before the dispatch loop
* make the `TestReaderLatestInclusiveHasNext` test case be more robust
rueian added a commit to rueian/pulsar-client-go that referenced this pull request Feb 16, 2021
@rueian
Fix reader with start latest message id inclusive (apache#329)
f6d4939 
Fixes apache#356
Fixes apache#419

Motivtions

The changes made by the original PR apache#329 are no longer works.
This PR is trying to fix the bugs and make the test case be more robust.

Moditications

* fix the wrong comparison `pc.startMessageID == lastestMessageID` with `pc.startMessageID.equal(lastestMessageID.(messageID))`
* fix the hanging `pc.requestSeek(msgID.messageID)` with `pc.requestSeekWithoutClear(msgID.messageID)` before the dispatch loop
* make the `TestReaderLatestInclusiveHasNext` test case be more robust
wolfstudy pushed a commit that referenced this pull request Feb 19, 2021
@rueian
Fix reader with start latest message id inclusive (#329) (#467)
7d53914 
* Fix reader with start latest message id inclusive (#329)

Fixes #356
Fixes #419

Motivtions

The changes made by the original PR #329 are no longer works.
This PR is trying to fix the bugs and make the test case be more robust.

Moditications

* fix the wrong comparison `pc.startMessageID == lastestMessageID` with `pc.startMessageID.equal(lastestMessageID.(messageID))`
* fix the hanging `pc.requestSeek(msgID.messageID)` with `pc.requestSeekWithoutClear(msgID.messageID)` before the dispatch loop
* make the `TestReaderLatestInclusiveHasNext` test case be more robust

* Renew the expired certs in integration-tests with script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wolfstudy wolfstudy wolfstudy approved these changes
@merlimat merlimat Awaiting requested review from merlimat

Assignees

@quintans quintans

Labels

area/reader

Projects

None yet

Milestone

0.2.0

Development

Successfully merging this pull request may close these issues.

HasNext returns false when reading last message inclusive

2 participants

@quintans @wolfstudy