Clearing message queues after seek requests - #419
Merged
Conversation
Signed-off-by: milos-matijasevic <milosmatijasevic2015@gmail.com>
Signed-off-by: milos-matijasevic <milosmatijasevic2015@gmail.com>
wolfstudy
approved these changes
Jan 4, 2021
sijie
approved these changes
Jan 8, 2021
rueian
added a commit
to rueian/pulsar-client-go
that referenced
this pull request
Feb 15, 2021
Fixes apache#356 Fixes apache#419 Motivtions The changes made by the original PR apache#329 are no longer works. This PR is trying to fix the bugs and make the test case be more robust. Moditications * fix the wrong `pc.startMessageID == lastestMessageID` with `pc.startMessageID.equal(lastestMessageID.(messageID))` * fix the hanging `pc.requestSeek(msgID.messageID)` with `pc.requestSeekWithoutClear(msgID.messageID)` before the dispatch loop * make `HasNext()` return true in case of `StartMessageIdInclusive` and `LastestMessageID` * make `TestReaderLatestInclusiveHasNext` test case be more robust
1 task
rueian
added a commit
to rueian/pulsar-client-go
that referenced
this pull request
Feb 16, 2021
Fixes apache#356 Fixes apache#419 Motivtions The changes made by the original PR apache#329 are no longer works. This PR is trying to fix the bugs and make the test case be more robust. Moditications * fix the wrong `pc.startMessageID == lastestMessageID` with `pc.startMessageID.equal(lastestMessageID.(messageID))` * fix the hanging `pc.requestSeek(msgID.messageID)` with `pc.requestSeekWithoutClear(msgID.messageID)` before the dispatch loop * make `TestReaderLatestInclusiveHasNext` test case be more robust
rueian
added a commit
to rueian/pulsar-client-go
that referenced
this pull request
Feb 16, 2021
Fixes apache#356 Fixes apache#419 Motivtions The changes made by the original PR apache#329 are no longer works. This PR is trying to fix the bugs and make the test case be more robust. Moditications * fix the wrong `pc.startMessageID == lastestMessageID` with `pc.startMessageID.equal(lastestMessageID.(messageID))` * fix the hanging `pc.requestSeek(msgID.messageID)` with `pc.requestSeekWithoutClear(msgID.messageID)` before the dispatch loop * make the `HasNext()` return true in case of `StartMessageIdInclusive` and `LastestMessageID` * make the `TestReaderLatestInclusiveHasNext` test case be more robust
rueian
added a commit
to rueian/pulsar-client-go
that referenced
this pull request
Feb 16, 2021
Fixes apache#356 Fixes apache#419 Motivtions The changes made by the original PR apache#329 are no longer works. This PR is trying to fix the bugs and make the test case be more robust. Moditications * fix the wrong `pc.startMessageID == lastestMessageID` with `pc.startMessageID.equal(lastestMessageID.(messageID))` * fix the hanging `pc.requestSeek(msgID.messageID)` with `pc.requestSeekWithoutClear(msgID.messageID)` before the dispatch loop * make the `TestReaderLatestInclusiveHasNext` test case be more robust
rueian
added a commit
to rueian/pulsar-client-go
that referenced
this pull request
Feb 16, 2021
Fixes apache#356 Fixes apache#419 Motivtions The changes made by the original PR apache#329 are no longer works. This PR is trying to fix the bugs and make the test case be more robust. Moditications * fix the wrong comparison `pc.startMessageID == lastestMessageID` with `pc.startMessageID.equal(lastestMessageID.(messageID))` * fix the hanging `pc.requestSeek(msgID.messageID)` with `pc.requestSeekWithoutClear(msgID.messageID)` before the dispatch loop * make the `TestReaderLatestInclusiveHasNext` test case be more robust
wolfstudy
pushed a commit
that referenced
this pull request
Feb 19, 2021
* Fix reader with start latest message id inclusive (#329) Fixes #356 Fixes #419 Motivtions The changes made by the original PR #329 are no longer works. This PR is trying to fix the bugs and make the test case be more robust. Moditications * fix the wrong comparison `pc.startMessageID == lastestMessageID` with `pc.startMessageID.equal(lastestMessageID.(messageID))` * fix the hanging `pc.requestSeek(msgID.messageID)` with `pc.requestSeekWithoutClear(msgID.messageID)` before the dispatch loop * make the `TestReaderLatestInclusiveHasNext` test case be more robust * Renew the expired certs in integration-tests with script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Message queues should be cleared after seek requests (
SeekandSeekByTime). If this is not performed messages that stay in message queues will be consumed before the sough message.Modifications
Cleaning
queueChandmessageChafter successful seek request in partition_consumer.go.Verifying this change
This change is already covered by existing tests, such as
TestConsumerSeekByTimeandTestConsumerSeek.This change added tests and can be verified as follows:
TestConsumerSeekByTimeandTestConsumerSeektest for consuming correctly sought message even if some messages stay in message queues.Does this pull request potentially affect one of the following parts:
Documentation