Skip to content

fix retryLetterProducer usr auto_chema - #11550

Closed
Johnnyhooyo wants to merge 1 commit into
apache:masterfrom
Johnnyhooyo:feature_fix_11474
Closed

fix retryLetterProducer usr auto_chema#11550
Johnnyhooyo wants to merge 1 commit into
apache:masterfrom
Johnnyhooyo:feature_fix_11474

Conversation

@Johnnyhooyo

@Johnnyhooyo Johnnyhooyo commented Aug 4, 2021

Copy link
Copy Markdown

link to #11474

@codelipenghui codelipenghui added this to the 2.9.0 milestone Aug 4, 2021
@Anonymitaet

Anonymitaet commented Aug 5, 2021

Copy link
Copy Markdown
Member

Thanks for your contribution. For this PR, do we need to update docs?

(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@Johnnyhooyo

Johnnyhooyo commented Aug 11, 2021

Copy link
Copy Markdown
Author

Thanks for your contribution. For this PR, do we need to update docs?

(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

maybe this PR do not need update Docs, because the modified logic is normal logic and does not need to be repeated

@Anonymitaet Anonymitaet added the doc-not-needed Your PR changes do not impact docs label Aug 11, 2021
congbobo184
congbobo184 reviewed Aug 11, 2021
View reviewed changes

@congbobo184 congbobo184 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! could you please add some test for it? like: #9970

@eolivelli eolivelli modified the milestones: 2.9.0, 2.10.0 Oct 6, 2021
@codelipenghui codelipenghui modified the milestones: 2.10.0, 2.11.0 Jan 18, 2022
@codelipenghui

codelipenghui commented Mar 4, 2022

Copy link
Copy Markdown
Contributor

The pr had no activity for 30 days, mark with Stale label.

@codelipenghui codelipenghui modified the milestones: 2.11.0, 2.12.0 Jul 26, 2022
@tisonkun

tisonkun commented Dec 25, 2022

Copy link
Copy Markdown
Member

Closed as stale. I make a follow-up at #19051. Please take a look.

This original author is marked as co-author.

@tisonkun tisonkun closed this Dec 25, 2022
@tisonkun tisonkun mentioned this pull request Dec 25, 2022
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@congbobo184 congbobo184 congbobo184 left review comments
@gaoran10 gaoran10 Awaiting requested review from gaoran10

Assignees

@Johnnyhooyo Johnnyhooyo

Labels

doc-not-needed Your PR changes do not impact docs lifecycle/stale

Projects

None yet

Milestone

3.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@Johnnyhooyo @Anonymitaet @codelipenghui @tisonkun @congbobo184 @eolivelli