Skip to content

fix retryLetterProducer usr auto_chema #11550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Johnnyhooyo wants to merge 1 commit into from
Closed

fix retryLetterProducer usr auto_chema #11550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions pulsar-client/src/main/java/org/apache/pulsar/client/impl/ConsumerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ public class ConsumerImpl<T> extends ConsumerBase<T> implements ConnectionHandle

private volatile CompletableFuture<Producer<byte[]>> deadLetterProducer;

private volatile Producer<T> retryLetterProducer;
private volatile Producer<byte[]> retryLetterProducer;
private final ReadWriteLock createProducerLock = new ReentrantReadWriteLock();

protected volatile boolean paused;
Expand Down Expand Up @@ -559,7 +559,7 @@ protected CompletableFuture<Void> doReconsumeLater(Message<?> message, AckType a
createProducerLock.writeLock().lock();
try {
if (retryLetterProducer == null) {
retryLetterProducer = client.newProducer(schema)
retryLetterProducer = client.newProducer(Schema.AUTO_PRODUCE_BYTES(schema))
.topic(this.deadLetterPolicy.getRetryLetterTopic())
.enableBatching(false)
.blockIfQueueFull(false)
Expand Down Expand Up @@ -612,8 +612,9 @@ protected CompletableFuture<Void> doReconsumeLater(Message<?> message, AckType a
return null;
});
} else {
TypedMessageBuilder<T> typedMessageBuilderNew = retryLetterProducer.newMessage()
.value(retryMessage.getValue())
assert retryMessage != null;
TypedMessageBuilder<byte[]> typedMessageBuilderNew = retryLetterProducer.newMessage()
.value(retryMessage.getData())
.properties(propertiesMap);
if (delayTime > 0) {
typedMessageBuilderNew.deliverAfter(delayTime, unit);
Expand Down