Use get instead of join to avoid getting stuck - #11597
Merged
Merged
Conversation
eolivelli
requested changes
Aug 8, 2021
eolivelli
left a comment
eolivelli
left a comment
Contributor
There was a problem hiding this comment.
Overall the patch LGTM
But I left few comments
codelipenghui
approved these changes
Aug 9, 2021
LeBW
pushed a commit
to LeBW/pulsar
that referenced
this pull request
Aug 9, 2021
Contributor
|
This PR depend on #11265 , which is a feature. we move this pr to 2.8.2 first. |
codelipenghui
pushed a commit
that referenced
this pull request
Sep 24, 2021
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 27, 2021
…tuck (apache#12110) (cherry picked from commit 5de46f9)
1 task
1 task
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
join() will not time out, when network jitter occurs, it is easy to cause the thread to get stuck forever
Modifications
Use get(timeout) instead of join() to avoid getting stuck