[Cherry-pick] Use get instead of join to avoid getting stuck - #12110
Merged
Conversation
Contributor
Author
|
As AdminResource and ResourceQuotasBase are not using CompletableFuture, so don't need to modify. |
Contributor
Author
|
/pulsarbot run-failure-checks |
1 similar comment
Contributor
Author
|
/pulsarbot run-failure-checks |
codelipenghui
approved these changes
Sep 24, 2021
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Oct 27, 2021
…tuck (apache#12110) (cherry picked from commit 5de46f9)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry pick #11597 .
Motivation
join() will not time out, when network jitter occurs, it is easy to cause the thread to get stuck forever
Modifications
Use get(timeout) instead of join() to avoid getting stuck