Skip to content

[broker] Optimize deduplicationSnapshotIntervalSeconds with HierarchyTopicPolicies - #13769

Merged
codelipenghui merged 2 commits into
apache:masterfrom
Jason918:tp_deduplicationSnapshotIntervalSeconds
Jan 19, 2022
Merged

[broker] Optimize deduplicationSnapshotIntervalSeconds with HierarchyTopicPolicies#13769
codelipenghui merged 2 commits into
apache:masterfrom
Jason918:tp_deduplicationSnapshotIntervalSeconds

Conversation

@Jason918

Copy link
Copy Markdown
Contributor

Master Issue: #13756

Motivation

See #13756

Modifications

Add deduplicationSnapshotIntervalSeconds in HierarchyTopicPolicies.

Verifying this change

  • Make sure that the change passes the CI checks.

This change is already covered by existing tests, such as TopicDuplicationTest.java

Some checklist for updating topic policy with HierarchyTopicPolicies.

  • Broker level value set. And if it's dynamic (no).
  • Namespace level value updated.
  • Topic level value updated.
  • Pre-existing unit test covers this change and updated to verify this change.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • no-need-doc

Code optimization.

@github-actions github-actions Bot added the doc-not-needed Your PR changes do not impact docs label Jan 16, 2022
@mattisonchao

Copy link
Copy Markdown
Member

This PR needs to wait for #13772 to be merged, then close and reopen it.

@Jason918 Jason918 closed this Jan 17, 2022
@Jason918 Jason918 reopened this Jan 17, 2022
@codelipenghui

Copy link
Copy Markdown
Contributor

@Jason918 Please check the checkstyle violations

@Jason918
Jason918 force-pushed the tp_deduplicationSnapshotIntervalSeconds branch from 05860ca to d12494e Compare January 18, 2022 01:26
@Jason918

Copy link
Copy Markdown
Contributor Author

/pulsarbot run-failure-checks

1 similar comment
@Jason918

Copy link
Copy Markdown
Contributor Author

/pulsarbot run-failure-checks

@Jason918 Jason918 closed this Jan 18, 2022
@Jason918 Jason918 reopened this Jan 18, 2022
@Jason918

Copy link
Copy Markdown
Contributor Author

/pulsarbot run-failure-checks

2 similar comments
@Jason918

Copy link
Copy Markdown
Contributor Author

/pulsarbot run-failure-checks

@Jason918

Copy link
Copy Markdown
Contributor Author

/pulsarbot run-failure-checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc-not-needed Your PR changes do not impact docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants